Fix DoctrineConnectionFactoryFactory due to doctrine/common changes

[kdefives]

Fix #1085 - Fix to be compatible with doctrine v3 . Since Doctrine v3, seems some changes with doctrine/common

[Steveb-p]

@kdefives It will probably be fine just replacing the old interface with the new one, but we should probably also add conflict to composer.json with doctrine/persistence versions that did not have it yet. I had a quick look but could not determine since when it was introduced though.

[kdefives]

@kdefives It will probably be fine just replacing the old interface with the new one, but we should probably also add conflict to composer.json with doctrine/persistence versions that did not have it yet. I had a quick look but could not determine since when it was introduced though.

@Steveb-p I think it is recent because i started to developed my application 18 days ago and everything worked perfectly until yesterday when i executed a "composer update". Hope it will help you.

[Steveb-p]

@kdefives doctrine/persistence @1.3.0 introduces a compatibility layer (9 months ago):
doctrine/persistence@548f75f

Anything before that will break, because Doctrine\Persistence\ManagerRegistry class will not exist. Simple solution would be to mark doctrine/persistence < 1.3.0 as conflicting.

[kdefives]

@Steveb-p Sorry i did not understand what you mean.

When you say "Simple solution would be to mark doctrine/persistence < 1.3.0 as conflicting.". Do you mean here : https://github.com/kdefives/enqueue-dev/blob/patch-1/composer.json ?
Or in the composer.json of my application?

Because i tried to add this line in my composer.json of my application but i still have the issue:

"conflict": {
        "symfony/symfony": "*",
        "doctrine/persistence": "<1.3.0"
    },

My application is working perfectly if i change this line

"doctrine/doctrine-bundle": "^2.1",

by this line

"doctrine/doctrine-bundle": "v2.1.0",

Then, when i execute composer update i can see the downgrade:

Package operations: 0 installs, 3 updates, 0 removals
  - Downgrading doctrine/persistence (2.0.0 => 1.3.8): Loading from cache
  - Downgrading doctrine/doctrine-bundle (2.1.1 => 2.1.0): Loading from cache
  - Downgrading doctrine/common (3.0.2 => 2.13.3): Loading from cache

[Steveb-p]

@kdefives I'm specifically saying that switching DoctrineConnectionFactoryFactory to use Doctrine\Persistence\ManagerRegistry will cause projects that use doctrine/persistence lower than 1.3.0 to crash. Because of this we have to either add a compatibility layer (selecting one of the classes to be used as constructor argument depending on which is available) or mark previous versions as being in conflict (editing enqueue's composer.json to say so).

Marking as conflicting is an easy way out of the problem, however providing compatibility layer is a better solution (especially since persistence 1.3 is 9 months old).

[kdefives]

I did changes but there are still issues with test classes (as you can see the checks failed). I do not think to have enough time to work on it so if someone can finish this PR, feel free. Moreover, I think it could be useful for other people who starts new Symfony project.

Until new release with this fix, I fixed doctrine-bundle version as explained below, in my project.

Thx again for your help.
Regards

[nivpenso]

any news regarding that one?

[kricha]

any news?

[a-menshchikov]

What news about this PR?

[nivpenso]

I have created a follow-up PR (#1105) for this PR. hopefully, it will be merged soon