Make nullable parameters explicity nullable for PHP 8.4 #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

oscarotero merged 1 commit into php-embed:master from emteknetnz:php84-implicit-nullable

Dec 4, 2024

Contributor

emteknetnz commented Dec 4, 2024

Implicitly nullable parameter types are deprecated in PHP 8.4

https://www.php.net/manual/it/migration84.deprecated.php#migration84.deprecated.core.implicitly-nullable-parameter


          Make nullable parameters explicity nullable for PHP 8.4

e1dcf77

emteknetnz mentioned this pull request

Review third-party PHP 8.4 deprecations before 6.0.0-rc1 silverstripe/.github#351

Open

oscarotero merged commit e969571 into php-embed:master

emteknetnz deleted the php84-implicit-nullable branch

December 4, 2024 20:38

garrettw commented Dec 30, 2024 •

edited

Loading

Hi, I just wanted to let you know that this is a breaking change in a project I work on.

See MbinOrg/mbin#1324

Looks like it’s related to #552 and #553. Can we get a new patch release with that in it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet