Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Warning about inherit_metadata and UV always displayed #3438

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

frostming
Copy link
Collaborator

Fixes #3434

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fixes #3434

Signed-off-by: Frost Ming <me@frostming.com>
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (9f881da) to head (bb684fc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3438   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files         112      112           
  Lines       11548    11548           
  Branches     2533     2533           
=======================================
  Hits         9845     9845           
- Misses       1175     1176    +1     
+ Partials      528      527    -1     
Flag Coverage Δ
unittests 85.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frostming frostming merged commit 8ebd9c6 into main Apr 1, 2025
21 checks passed
@frostming frostming deleted the frostming/issue3434 branch April 1, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning about inherit_metadata and UV always displayed
1 participant