Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to prevent destroying the window when focus is lost #21

Closed
CraftedCart opened this issue Apr 16, 2017 · 2 comments
Closed

Option to prevent destroying the window when focus is lost #21

CraftedCart opened this issue Apr 16, 2017 · 2 comments

Comments

@CraftedCart
Copy link

CraftedCart commented Apr 16, 2017 •
edited
Loading

When the Plotinus window loses focus, it usually destroys the window. This is particulary irritating seeing as I have my WM configured to focus where the mouse is, so if the mouse doesn't happen to be over the Plotinus window, it sometimes gets destroyed immediately.

If you are interested if merging my changes, I submitted PR #22. I did notice you said you would prefer filing an issue first, but seeing as I added some code, I submitted the PR anyway. I added the option of setting the environment variable PLOTINUS_UNFOCUSED_PREVENT_CLOSE to true to prevent this default behaviour.
p-e-w added a commit that referenced this issue Apr 23, 2017
@p-e-w
Make popup window modal
d52b395 
Fixes #5 and #21
@p-e-w
Copy link
Owner

p-e-w commented Apr 23, 2017

Thank you for pointing this out!

As of d52b395, the popup window is no longer destroyed when it loses focus, so this is not an issue anymore.

@p-e-w p-e-w closed this as completed Apr 23, 2017
@CraftedCart
Copy link
Author

Ah ok - Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p-e-w @CraftedCart