Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-1052: Remove Validation for "At Least One Interface Must Be Defined for Each Node" #9405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pawanpinjarkar
Copy link
Contributor

Remove the validation so that agent-config.yaml can be valid even if no interfaces/mac-addresses are defined when defining host information.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 27, 2025

@pawanpinjarkar: This pull request references AGENT-1052 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Remove the validation so that agent-config.yaml can be valid even if no interfaces/mac-addresses are defined when defining host information.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bfournie and rwsu January 27, 2025 17:35
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pawanpinjarkar. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-host-groups-ovn-custom-no-upgrade 76c4576 link false /test e2e-vsphere-host-groups-ovn-custom-no-upgrade
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage 76c4576 link false /test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/integration-tests 76c4576 link true /test integration-tests
ci/prow/golint 76c4576 link true /test golint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants