WIP: CORS-3856: Add check for asset before destroy #9386
Conversation
Adding a check to see if PlatformProvisionCheck asset exists before initiating destroy cluster. This asset is only created during create cluster phase which means the user used that command to create the cluster and hence can be cleaned with no consequences. In the case of UPI, deleting a resource group would possibly delete other resources in the rg which might've been created by the user and could be something we shouldn't delete.
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@rna-afk: This pull request references CORS-3856 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold Discussed in slack, but I think we're leaning away from this direction due to the fact that this introduces a dependency on the install config for delete |
openshift-ci
bot
added
the
do-not-merge/hold
|
Closing this as it's no longer required |
Adding a check to see if PlatformProvisionCheck asset exists before initiating destroy cluster. This asset is only created during create cluster phase which means the user used that command to create the cluster and hence can be cleaned with no consequences.
In the case of UPI, deleting a resource group would possibly delete other resources in the rg which might've been created by the user and could be something we shouldn't delete.