Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297: Update OptionsCheckRule for new JDK releases #625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ky0n
Copy link
Contributor

@ky0n ky0n commented Jan 18, 2025

New cli-options were added for JDK release 22, 23 based on the official release notes (removed part and deprecated path)
https://www.oracle.com/java/technologies/javase/22-relnote-issues.html
https://www.oracle.com/java/technologies/javase/23-relnote-issues.html

I also updated existing depcrecated options in the array based on
this file in the jdk https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L516 which is regularly updated, i switched between git tags to find earlier options when they were part of the array. I did this to jdk10, but not before jdk version 10 for everything i could find. I can also update the arguments, which were obsoleted in jdk9.

Any feedback appreciated, thank you.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8297: Update OptionsCheckRule for new JDK releases (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/625/head:pull/625
$ git checkout pull/625

Update a local copy of the PR:
$ git checkout pull/625
$ git pull https://git.openjdk.org/jmc.git pull/625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 625

View PR using the GUI difftool:
$ git pr show -t 625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/625.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2025

👋 Welcome back ky0n! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 18, 2025

@ky0n This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297: Update OptionsCheckRule for new JDK releases

Reviewed-by: hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ff9adf5: 8349: JMC Copyright year and some http links require update

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Gunde) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr label Jan 18, 2025
@ky0n ky0n changed the title 8297: OptionsCheckRule jvm arguments 8297: Update OptionsCheckRule for new JDK releases Jan 18, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2025

Webrevs

@thegreystone thegreystone requested a review from Gunde January 19, 2025 23:28
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2025

@ky0n This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added the ready label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants