-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add connect to operations #3785
base: master
Are you sure you want to change the base?
docs: Add connect to operations #3785
Conversation
Signed-off-by: Martin Alexander <malexander@seismic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malexander2012 operation.md
refers to all the operations that gatekeeper supports, here is the list of it - https://github.com/open-policy-agent/gatekeeper/blob/master/pkg/operations/operations.go#L18. We enable gk webhooks to allow validation of connect
operations - https://github.com/open-policy-agent/gatekeeper/blob/master/charts/gatekeeper/templates/gatekeeper-validating-webhook-configuration-validatingwebhookconfiguration.yaml#L68 recently. We should close this PR if the interntion was to update the GK docs with latest information about supported operations.
You can add a new section for “how to enable validation of connect operations”, similar to: https://open-policy-agent.github.io/gatekeeper/website/docs/customize-admission/#how-to-enable-validation-of-delete-operations |
Sure thing. I'll add that section below the section you referenced. Thank you. |
Signed-off-by: Martin Alexander <malexander@seismic.com>
8c17035
to
55ac620
Compare
We should also update https://github.com/open-policy-agent/gatekeeper/tree/master/website/versioned_docs for 3.17+ since thats when this was added. |
ok. will add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after versioned docs change
Signed-off-by: Martin Alexander <malexander@seismic.com>
025a3eb
to
b2b9756
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating versioned docs.
Signed-off-by: Martin Alexander <malexander@seismic.com>
What this PR does / why we need it:
This adds
connect
to the operations doc.Which issue(s) this PR fixes (optional, using
Yes No Yesfixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes # N/A
Special notes for your reviewer:
Not sure what else to put in the
Required Behaviors
andPermissions Required
. Need a little help here.