fix: fixing nil pointer error when converting VAPB from v1beta1 to v1 and updating crypto, net (#3754) (#3766) #3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsmythe
approved these changes
Jan 16, 2025
maxsmythe
reviewed
Jan 16, 2025
| @@ -12,9 +13,12 @@ import ( | |||
| celSchema "github.com/open-policy-agent/frameworks/constraint/pkg/client/drivers/k8scel/schema" | |||
| regoSchema "github.com/open-policy-agent/frameworks/constraint/pkg/client/drivers/rego/schema" | |||
| "github.com/open-policy-agent/frameworks/constraint/pkg/core/templates" | |||
| "github.com/open-policy-agent/gatekeeper/v3/pkg/drivers/k8scel/transform" | |||
There was a problem hiding this comment.
I think the driver code was still in CF at this point
There was a problem hiding this comment.
Thanks! Updated the path. Should be good now.
…open-policy-agent#3754) Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> (cherry picked from commit 14e6c8a)
JaydipGabani
force-pushed
the
release-3.17
branch
from
c6b2109 to
5a95c29
Compare
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> (cherry picked from commit a8eb788)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-3.17 #3781 +/- ##
===============================================
Coverage ? 47.73%
===============================================
Files ? 219
Lines ? 18441
Branches ? 0
===============================================
Hits ? 8802
Misses ? 8824
Partials ? 815
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JaydipGabani
changed the title
dhaiducek
pushed a commit
to dhaiducek/gatekeeper
that referenced
this pull request
Jan 29, 2025
… and updating crypto, net (open-policy-agent#3754) (open-policy-agent#3766) (open-policy-agent#3781) Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jaydip Gabani gabanijaydip@gmail.com
(cherry picked from commit 14e6c8a)
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: