New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid compile time dependencies #536

Merged

zorbash merged 1 commit into open-api-spex:master from felt:master

May 5, 2023

Contributor

doorgan commented May 5, 2023 •

edited

Loading

It's common to pass schema structs as types for the parameters in an operation, like:

operation :foo,
  request_body: {"Request", "application/json", properties: %{bar: ApiSchemas.Bar}

Without escaping that module alias, this introduces a compile time dependency between the controller using operation and the schema module.

This PR fixes that. I'm not sure if this issue exists in other macros, but I think this same approach can be used in any place where this happens.


          Avoid compile time dependencies

517d98b

Contributor

zorbash commented May 5, 2023

See also phoenixframework/phoenix_live_view@f397224

zorbash merged commit 5d48652 into open-api-spex:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet