Skip to content

[IMP] Inventory: DHL Developer Portal #12902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

justinmallette
Copy link
Contributor

@robodoo
Copy link
Collaborator

robodoo commented Apr 15, 2025

Pull request status dashboard

@justinmallette
Copy link
Contributor Author

@jero-odoo ready for peer review. it looks like the whole article was rewritten, but I'm just canonizing 16.0 to what 17.0 looks like. Lines 69-90 and 126-134 were what was actually updated, so those are the only snippets that need review.

Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @justinmallette ! Just a few quick notes

Comment on lines +19 to +20
Before creating a DHL shipping method, enable the carrier's shipping connector.
To do so, navigate to :menuselection:`Inventory app --> Configuration --> Settings`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Before creating a DHL shipping method, enable the carrier's shipping connector.
To do so, navigate to :menuselection:`Inventory app --> Configuration --> Settings`.
Before creating a DHL shipping method, enable the carrier's shipping connector. To do so, navigate to :menuselection:`Inventory app --> Configuration --> Settings`.

Early line break (less than 100 characters)

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

A DHL SiteID, password, and account number are used to link a DHL account with third-party services,
like Odoo's **Inventory** app. The SiteID and password are different credentials than the ones used
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be worth breaking out into an "Important" admonition block. Not a requirement, but something to consider!

Once the DHL connection is set up, use the buttons at the top of the form to turn on or debug the
connection.

- **Unpublished/Published**: turns on or off the connection.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Unpublished/Published**: turns on or off the connection.
- **Unpublished/Published**: turns the connection on or off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants