-
Notifications
You must be signed in to change notification settings - Fork 9.1k
[IMP] Helpdesk: track and bill time #12890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hey @justinmallette this is ready for peer review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nitpicks from me! Looks really good
content/applications/services/helpdesk/advanced/track_and_bill.rst
Outdated
Show resolved
Hide resolved
content/applications/services/helpdesk/advanced/track_and_bill.rst
Outdated
Show resolved
Hide resolved
7954c55
to
d1af750
Compare
Thank you Justin! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jero-odoo !
Approved with super minor comments; gj as usual (:
content/applications/services/helpdesk/advanced/track_and_bill.rst
Outdated
Show resolved
Hide resolved
content/applications/services/helpdesk/advanced/track_and_bill.rst
Outdated
Show resolved
Hide resolved
content/applications/services/helpdesk/advanced/track_and_bill.rst
Outdated
Show resolved
Hide resolved
content/applications/services/helpdesk/advanced/track_and_bill.rst
Outdated
Show resolved
Hide resolved
content/applications/services/helpdesk/advanced/track_and_bill.rst
Outdated
Show resolved
Hide resolved
content/applications/services/helpdesk/advanced/track_and_bill.rst
Outdated
Show resolved
Hide resolved
b1c652d
to
fe9c553
Compare
Thank you Felicia! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo nice work! Your improvements look great to me!
Approving with one change:
This image is not used and can be removed helpdesk/advanced/track_and_bill.rst
Thank you for your work!
..
@robodoo delegate=jero-odoo
Co-authored-by: Justin Mallette <86990712+justinmallette@users.noreply.github.com> Co-authored-by: Felicia Kuan <feku@odoo.com>
fe9c553
to
4435ceb
Compare
@robodoo r+ |
Updating Track and Bill time doc for v18
Updating content and images to reflect UI changes and updated style guidelines.