-
Notifications
You must be signed in to change notification settings - Fork 9.1k
[ADD] purchase: suggested qty #12871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hiii @samueljlieber 🙈 I'm trying to document an unreleased feature set to deploy to saas-18.3 and thought to set the target to master, since that branch isn't available yet. However, I got that traceback issue. Do you have any idea what's going on? 😭 |
@Felicious This traceback is caused by the new |
OH MY GOODNESS 🙈 noob mistake. Thank you!! |
8ce0da4
to
84a862a
Compare
84a862a
to
e10109a
Compare
Hi @jero-odoo ! Could I get your help reviewing this brand new feature coming to 18.3? 😊 You'll have to test in the master runbot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Felicious great work! I had a few comments, mostly on formatting (the math markups were building oddly, I think I have fixed them but you will definitely want to take a second look!) Otherwise everything looks good to me!
one other thing to note, when I was looking through RFQs, there was a few that weren't displaying the "Suggest" button. I wasn't able to find any similarities, so I can't say for sure why or why not the button would appear. (Also it was a runbot so I can't say for sure it wasn't just an error). I am not sure if there is any other information we have on why the button would not be available but if so, that would be a nice addition.
Let me know if you have any questions, thanks!
- *Replenish for*: Number of days to cover future demand. | ||
- *Based on*: Period used to calculate average daily demand (e.g., last 7 days, last 30 days, last 3 | ||
months, last 12 months, or a past month/quarter). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- *Replenish for*: Number of days to cover future demand. | |
- *Based on*: Period used to calculate average daily demand (e.g., last 7 days, last 30 days, last 3 | |
months, last 12 months, or a past month/quarter). | |
- *Replenish for*: number of days to cover future demand. | |
- *Based on*: period used to calculate average daily demand (e.g., last 7 days, last 30 days, last 3 | |
months, last 12 months, or a past month/quarter). |
I know we have gone back and forth on this, but I think we settled on capital letter after : if it is a full sentence, if not, lower case.
|
||
.. |RFQ| replace:: :abbr:`RFQ (request for quotation)` | ||
|
||
For a straightforward push-based replenishment strategy the *Suggest* feature recommends quantities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a straightforward push-based replenishment strategy the *Suggest* feature recommends quantities | |
For a straightforward push-based replenishment strategy, the *Suggest* feature recommends quantities |
#. **Purchase** and **Inventory** apps must be installed | ||
#. :ref:`Validate at least one delivery order <inventory/delivery/one-step>` for each product | ||
|
||
Ensures there is a past delivery record so the system can calculate average daily demand. | ||
|
||
#. :ref:`Add a vendor to the vendor pricelist <purchase/manage_deals/vendor-pricelist>` with a | ||
purchase price for each product | ||
|
||
The *Suggest* feature is vendor-specific, so each product needs a matching vendor for accurate | ||
purchase quantity and price suggestions. | ||
|
||
#. Set the *Product Type* to *Goods* and ensure the product is :ref:`Tracked by quantity | ||
<inventory/product_management/manufacture>` | ||
|
||
Ensures the system can manage stock levels and calculate recommended replenishment quantities for | ||
tangible items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#. **Purchase** and **Inventory** apps must be installed | |
#. :ref:`Validate at least one delivery order <inventory/delivery/one-step>` for each product | |
Ensures there is a past delivery record so the system can calculate average daily demand. | |
#. :ref:`Add a vendor to the vendor pricelist <purchase/manage_deals/vendor-pricelist>` with a | |
purchase price for each product | |
The *Suggest* feature is vendor-specific, so each product needs a matching vendor for accurate | |
purchase quantity and price suggestions. | |
#. Set the *Product Type* to *Goods* and ensure the product is :ref:`Tracked by quantity | |
<inventory/product_management/manufacture>` | |
Ensures the system can manage stock levels and calculate recommended replenishment quantities for | |
tangible items. | |
#. **Purchase** and **Inventory** apps must be installed | |
#. :ref:`Validate at least one delivery order <inventory/delivery/one-step>` for each product. | |
Ensures there is a past delivery record so the system can calculate average daily demand. | |
#. :ref:`Add a vendor to the vendor pricelist <purchase/manage_deals/vendor-pricelist>` with a | |
purchase price for each product. | |
The *Suggest* feature is vendor-specific, so each product needs a matching vendor for accurate | |
purchase quantity and price suggestions. | |
#. Set the *Product Type* to *Goods* and ensure the product is :ref:`Tracked by quantity | |
<inventory/product_management/manufacture>`. | |
Ensures the system can manage stock levels and calculate recommended replenishment quantities for | |
tangible items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting on this section is a little odd in the build (there are extra line breaks). I didn't make changes beyond adding some punctuation but you may want to take another look.
- :guilabel:`Replenish for`: Number of days intended to stock products | ||
- :guilabel:`Based on`: Historical period used to calculate average daily demand (e.g., | ||
:guilabel:`Last 30 Days`, :guilabel:`April 2024`) | ||
|
||
- :guilabel:`Percentage`: Portion of historical demand to apply (e.g., 100%, 30%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- :guilabel:`Replenish for`: Number of days intended to stock products | |
- :guilabel:`Based on`: Historical period used to calculate average daily demand (e.g., | |
:guilabel:`Last 30 Days`, :guilabel:`April 2024`) | |
- :guilabel:`Percentage`: Portion of historical demand to apply (e.g., 100%, 30%) | |
- :guilabel:`Replenish for`: Number of days intended to stock products. | |
- :guilabel:`Based on`: Historical period used to calculate average daily demand (e.g., | |
:guilabel:`Last 30 Days`, :guilabel:`April 2024`). | |
- :guilabel:`Percentage`: Portion of historical demand to apply (e.g., 100%, 30%). |
.. image:: suggest/suggest-14.png | ||
:alt: Compute suggestion for example 1. | ||
|
||
Historical Data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very small nitpick, but it might be worth formatting this as a header
|
||
.. math:: | ||
|
||
Average~Daily~Demand = 40 \divide 30 \approx 1.33 \text{units/day} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Average~Daily~Demand = 40 \divide 30 \approx 1.33 \text{units/day} | |
Average~Daily~Demand = {40/30} \approx 1.33 \text{units/day} |
This formula was formatting oddly, I think this is correct, but you will want to double check!
|
||
.. math:: | ||
|
||
Average~Daily~Demand = 40 \divide 14 \approx 5.71 \text{units/day} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Average~Daily~Demand = 40 \divide 14 \approx 5.71 \text{units/day} | |
Average~Daily~Demand = {40/14} \approx 5.71 \text{units/day} |
Same as above, the formula formatted oddly, I think this one is correct
Best practices | ||
============== | ||
|
||
#. Validate Historical Data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is optional, but instead of using a numbered list format, I would consider changing this to header format. That would add these to the table of contents at the side of the page, so it is easier for users to navigate/recognize them
Adds the Suggest feature to compute recommended reorder amounts in purchase orders based on validated delivery data.
Merge documentation to saas-18.3 after this R&D task and PR have launched.