[IMP] sale_amazon: sell FBA and FBM at the same time #12796
Conversation
|
|
lipiraux
force-pushed
the
master-amazon-is-offer-fbm-lipi
branch
4 times, most recently
from
40e17b6 to
1d5b7ad
Compare
lipiraux
force-pushed
the
master-amazon-is-offer-fbm-lipi
branch
3 times, most recently
from
a8be108 to
04772a3
Compare
StraubCreative
force-pushed
the
master-amazon-is-offer-fbm-lipi
branch
2 times, most recently
from
f7b2142 to
8d58a95
Compare
StraubCreative
force-pushed
the
master-amazon-is-offer-fbm-lipi
branch
from
8d58a95 to
1a0495d
Compare
|
1a0495d: address failed |
StraubCreative
force-pushed
the
master-amazon-is-offer-fbm-lipi
branch
from
1a0495d to
41dede9
Compare
|
41dede9: |
There was a problem hiding this comment.
Looks good. Thank you for your contribution @lipiraux!
ci/minimal wouldn't pass with these two commits included.
- May have to manually rebase all branches (including Community and Enterprise) before merging, or set the merge method here to "rebase on merge" ?
Delegating to you:
@robodoo delegate=lipiraux
Previously, Odoo limited offers of the same product to be sold in either FBM or FBA. This limitation was caused by a lack of information on the Odoo side that distinguished fulfillment channels on a per-product basis, which did not permit the creation of multiple offers with different channels. With odoo/enterprise#78293, the fulfillmment channel of an offer is tracked with each new orders coming in. This allows a product to be sold in both FBA and FBM at the same time. task-4092410 Co-authored-by: StraubCreative <zst@odoo.com>
lipiraux
force-pushed
the
master-amazon-is-offer-fbm-lipi
branch
from
41dede9 to
f5daf69
Compare
|
Hello @StraubCreative , thanks for your review. I’m very sorry, but I need to make a small correction. It turns out that the information I added is not necessary because it’s a corner case that most users won’t encounter. Therefore, we only need to remove the part that states that the product could only be sold in one of FBA or FBM at the time. Could you please confirm that everything is good to go? Again, sorry to ask again. Note that the ci/minimal is failing again cause I did not rebase the enterprise version. Im waiting for a final review, and I will rebase everything afterward. |
There was a problem hiding this comment.
Hello @lipiraux 🦆
TBH, this could be done in 17.0 and forward-ported, as even there, since the API changes, it's now supported.
|
Closing in favor of #12901 |
Previously, Odoo limited offers of the same product to be sold in either FBM or FBA. This limitation was caused by a lack of information on the Odoo side that distinguished fulfillment channels on a per-product basis, which did not permit the creation of multiple offers with different channels.
With odoo/enterprise#78293, the fulfillmment channel of an offer is tracked with each new orders coming in. This allows a product to be sold in both FBA and FBM at the same time.
task-4092410