fix: specifically use serde::Serialize in Scalar derive #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cynic-querygen-web canceled.
|
To avoid problems with `Decimal` and any other type that has a built in `serialize` function.
obmarg
force-pushed
the
obmarg/push-muqnpspwpokn
branch
from
f6daa2a to
88a6c4b
Compare
Merged
obmarg
added a commit
that referenced
this pull request
Apr 12, 2024
## 🤖 New release * `cynic`: 3.5.1 -> 3.5.2 (✓ API compatible changes) * `cynic-proc-macros`: 3.5.1 -> 3.5.2 * `cynic-codegen`: 3.5.1 -> 3.5.2 (✓ API compatible changes) * `cynic-parser`: 0.2.1 -> 0.2.2 (✓ API compatible changes) * `cynic-cli`: 3.5.1 -> 3.5.2 * `cynic-introspection`: 3.5.1 -> 3.5.2 * `cynic-querygen`: 3.5.1 -> 3.5.2 <details><summary><i><b>Changelog</b></i></summary><p> ## `cynic` <blockquote> ## [3.5.2](v3.5.1...v3.5.2) - 2024-04-12 ### Fixed - specifically use serde::Serialize in Scalar derive ([#909](#909)) - merge problems in cynic-codegen ([#896](#896)) - better type kind mismatch errors ([#889](#889)) ### Other - unintentional recursion panic ([#890](#890)) - remove last criterion benchmark ([#898](#898)) - Update cynic-codegen to use cynic-parser ([#824](#824)) - concurrency on release task & remove a TODO ([#884](#884)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Signed-off-by: cynic-releaser[bot] <166170668+cynic-releaser[bot]@users.noreply.github.com> Co-authored-by: cynic-releaser[bot] <166170668+cynic-releaser[bot]@users.noreply.github.com> Co-authored-by: Graeme Coupar <graeme@turbofish.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we making this change?
It was reported here that
rust_decimal::Decimalerrored out whenderive(cynic::Scalar)was used on it. This turned out to be because thatDecimaltype defines its ownserializefunction in addition to implementingSerializeand theScalarderive was accidentally using that.What effects does this change have?
Updaates the
Scalarderive to specifically useserde::Serialize::serialize