feat: add variable inlining to OperationBuilder #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cynic-querygen-web canceled.
|
obmarg
force-pushed
the
obmarg/ztmmzmuwolwr
branch
from
97b5ed5 to
bc71a86
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we making this change?
Now that a49710 is merged it's quite easy to extract an
InputLiteralfrom aQueryVariablesstruct by the name of the variable. This makes it very easy to add variable inlining as a first class feature, rather than recommending post-processing as in #1007.What effects does this change have?
Adds a new
build_with_variables_inlinedfunction toOperationBuilderthat is available whenVariablesimplementsQueryVariableLiterals. This will return anOperationwith no variables entry and all the variables added into thequerystring as arguments.I had wanted to do this as a setting inside the builder, but getting the types to work with that was tricky - so another build function seemed the best option.