Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify references to TrueType fonts #27

Closed

Conversation

radarhere
Copy link

Suggestion for python-pillow#7600

In ImageDraw,

The default alignment is top left, specifically la for horizontal text with a TrueType font and lt otherwise. See :ref:text-anchors for details. This parameter is ignored for non-TrueType fonts.

I look at this and think

Ok, so it is la if it's horizontal text AND TrueType, and lt the rest of the time... oh, no, that's not it, "This parameter is ignored for non-TrueType fonts"

So I'm suggesting this instead.

The default alignment is top left, specifically la for horizontal text and lt for vertical text. See :ref:text-anchors for details. This parameter is ignored for non-TrueType fonts.

@djhoese
Copy link

djhoese commented Dec 8, 2023

I think I prefer this too, but I understand what @nulano was going for. I think the way it is in the Pillow PR is the "developer view" of the situation and the suggestions in this PR seem more like "the user" point of view. It also mirrors other argument documentation that are ignored/unused for non-truetype fonts.

@nulano
Copy link
Owner

nulano commented Dec 8, 2023

I have seen this PR, but I've been really busy this week - I should have time to think about this around the weekend or early next week.

@radarhere
Copy link
Author

Sure, no rush.

@nulano nulano force-pushed the anchor-clarify-docs branch from 96a0a28 to af2d976 Compare December 12, 2023 16:22
@nulano
Copy link
Owner

nulano commented Dec 12, 2023

Ok, I've updated python-pillow#7600 to use the same wording for both files.

@nulano nulano closed this Dec 12, 2023
@radarhere radarhere deleted the anchor-clarify-docs branch December 12, 2023 20:17
radarhere added a commit that referenced this pull request Nov 30, 2024
Update/remove references to CHANGES.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants