tools: do not throw on missing create-release-proposal.sh
#56704
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
jasnell
approved these changes
Jan 22, 2025
aduh95
added
author ready
bnb
approved these changes
Jan 22, 2025
RafaelGSS
approved these changes
Jan 23, 2025
aymen94
approved these changes
Jan 23, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1921371 |
aduh95
added a commit
that referenced
this pull request
Jan 27, 2025
PR-URL: #56704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95
added a commit
that referenced
this pull request
Jan 30, 2025
PR-URL: #56704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#56695 failed at doing that, it's simply easier to not go through the file system and simply pipe the output of the
curlcommand directly