Json schema improvements #218
Open
+49
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirpedrol
reviewed
Mar 25, 2025
| "MTMALIGN", | ||
| "FOLDMASON" | ||
| ], | ||
| "errorMessage": "align name must be provided, has to be a string, cannot contain spaces and must be one of: CLUSTALO, FAMSA, KALIGN, LEARNMSA, MAFFT, MAGUS, MUSCLES, TCOFFEE, REGRESSIVE, UPP, 3DCOFFE, MTMALIGN or FOLDMASON", |
There was a problem hiding this comment.
I am not sure we want to make this fail. It's a nice addition, but providing a wrong value won't make the pipeline fail, it will just not run.
In any case if we add this here we should update the docs on how to contribute.
What is your opinion @luisas
There was a problem hiding this comment.
I think it is fine that we let it fail, but yes we need to update the contributing logs! :)
We should add this to this PR before merging - I will try to do it today :)
There was a problem hiding this comment.
Awesome thank you! Let me know if you want me to do anything else :)
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the JSON schemas to make validation better