-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Important! Template update for nf-core/tools v3.1.0 #429
Conversation
@nf-core-bot fix linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tiny tweaks to manifest @jasmezz then you can merge
Ah @jasmezz tests fail because assert new File("$outputDir/pipeline_info/nf_core_pipeline_software_mqc_versions.yml").exists() should now be assert new File("$outputDir/pipeline_info/nf_core_funcscan_software_mqc_versions.yml").exists() (or something like that, check the relevant code change in the PR :) ) |
|
@nf-core-bot fix linting |
.vscode/settings.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, no!
Co-authored-by: Jasmin Frangenberg <73216762+jasmezz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK but please make last couple of changes before merging!
Version
3.1.0
of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the
nf-core-template-merge-3.1.0
branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.
For more information about this release of nf-core/tools, please see the
v3.1.0
release page.