Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deeparg/deepbgc versions #324

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Update deeparg/deepbgc versions #324

merged 4 commits into from
Dec 13, 2023
+119 −105

Conversation

jasmezz
Copy link
Collaborator

@jasmezz jasmezz commented Dec 8, 2023 •
edited
Loading

Updated and tested DeepARG, DeepBGC, and MultiQC versions.
(Additionally, a general modules update includes the environment.yml files of all modules.)

Edit: Additionally to the DeepARG update, I removed the separate DeepARG test profile because its database download is now stable (Zenodo). Hence the corresponding CI tests fail (but succeeded before this edit).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/funcscan branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 69b7a46

+| ✅ 159 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-12-08 14:09:10

@louperelo louperelo self-requested a review December 13, 2023 09:13
louperelo
louperelo approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@louperelo louperelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jasmezz jasmezz merged commit 38da7c2 into dev Dec 13, 2023
@jasmezz jasmezz deleted the modules-update branch December 13, 2023 13:22
@jasmezz jasmezz mentioned this pull request Jul 29, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louperelo louperelo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasmezz @louperelo