Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HTTP-POST for single logout service #82

Closed
jaebischer opened this issue Jan 27, 2017 · 3 comments · Fixed by #340
Closed

Allow HTTP-POST for single logout service #82

jaebischer opened this issue Jan 27, 2017 · 3 comments · Fixed by #340

Comments

@jaebischer
Copy link

My SAML IDP (Big-IP F5 APM) does only support HTTP-POST for single logout service. However Nextcloud does not accept POST requests to URL /saml/sls. Is it possible to support HTTP-POST requests for SAML single logout service?

@LukasReschke
Copy link
Member

LukasReschke commented Jan 27, 2017

That certainly makes sense and I'd be happy to review and accept a Pull Request on this. As the features that I'm working here for the SAML app is mainly influenced by customer demand from Nextcloud GmbH customers this is however not a priority for now.

So I won't have time to work on this on my own until this changes.

@smidt
Copy link

smidt commented Mar 4, 2019

Seems like the same issue here. UCS 4.3 + Nextcloud 14.0.6-1

ghost pushed a commit to fschrempf/user_saml that referenced this issue Jun 8, 2019
Some IdPs send their SLO logout requests via POST. To handle
them we need to add an entry in the routing table.
Further, we need to hack around the issue, that php-saml only
handles GET by copying the request from $_POST to $_GET.

This solves nextcloud#82.

Signed-off-by: Frieder Schrempf <fr.sc@online.de>
ghost pushed a commit to fschrempf/user_saml that referenced this issue Jun 8, 2019
Some IdPs send their SLO logout requests via POST. To handle
them we need to add an entry in the routing table.
Further, we need to hack around the issue, that php-saml only
handles GET by copying the request from $_POST to $_GET.

This solves nextcloud#82.

Signed-off-by: Frieder Schrempf <fr.sc@online.de>
ghost pushed a commit to fschrempf/user_saml that referenced this issue Jun 8, 2019
Some IdPs send their SLO logout requests via POST. To handle
them we need to add an entry in the routing table.
Further, we need to hack around the issue, that php-saml only
handles GET by copying the request from $_POST to $_GET.

This solves nextcloud#82.

Signed-off-by: Frieder Schrempf <fr.sc@online.de>
ghost pushed a commit to fschrempf/user_saml that referenced this issue Jun 8, 2019
Some IdPs send their SLO logout requests via POST. To handle
them we need to add an entry in the routing table.
Further, we need to hack around the issue, that php-saml only
handles GET by copying the request from $_POST to $_GET.

This solves nextcloud#82.

Signed-off-by: Frieder Schrempf <fr.sc@online.de>
ghost pushed a commit to fschrempf/user_saml that referenced this issue Jun 8, 2019
Some IdPs send their SLO logout requests via POST. To handle
them we need to add an entry in the routing table.
Further, we need to hack around the issue, that php-saml only
handles GET by copying the request from $_POST to $_GET.

This solves nextcloud#82.

Signed-off-by: Frieder Schrempf <fr.sc@online.de>
ghost pushed a commit to fschrempf/user_saml that referenced this issue Jun 8, 2019
Some IdPs send their SLO logout requests via POST. To handle
them we need to add an entry in the routing table.
Further, we need to hack around the issue, that php-saml only
handles GET by copying the request from $_POST to $_GET.

This solves nextcloud#82.

Signed-off-by: Frieder Schrempf <fr.sc@online.de>
ghost pushed a commit to fschrempf/user_saml that referenced this issue Jun 8, 2019
Some IdPs send their SLO logout requests via POST. To handle
them we need to add an entry in the routing table.
Further, we need to hack around the issue, that php-saml only
handles GET by copying the request from $_POST to $_GET.

This solves nextcloud#82.

Signed-off-by: Frieder Schrempf <fr.sc@online.de>
ghost pushed a commit to fschrempf/user_saml that referenced this issue Jun 8, 2019
Some IdPs send their SLO logout requests via POST. To handle
them we need to add an entry in the routing table.
Further, we need to hack around the issue, that php-saml only
handles GET by copying the request from $_POST to $_GET.

This solves nextcloud#82.

Signed-off-by: Frieder Schrempf <fr.sc@online.de>
@ghost ghost mentioned this issue Jun 8, 2019
@ghost
Copy link

ghost commented Jun 8, 2019

I have a fix (or maybe better call it a hack) for this issue: fschrempf@c8f6021

It's based on #334 and as soon as it is merged, I will send a PR for this.

ghost pushed a commit to fschrempf/user_saml that referenced this issue Jun 17, 2019
Some IdPs send their SLO logout requests via POST. To handle
them we need to add an entry in the routing table.
Further, we need to hack around the issue, that php-saml only
handles GET by copying the request from $_POST to $_GET.

This solves nextcloud#82.

Signed-off-by: Frieder Schrempf <frieder.schrempf@online.de>
ghost pushed a commit to fschrempf/user_saml that referenced this issue Jun 17, 2019
Some IdPs send their SLO logout requests via POST. To handle
them we need to add an entry in the routing table.
Further, we need to hack around the issue, that php-saml only
handles GET by copying the request from $_POST to $_GET.

This solves nextcloud#82.

Signed-off-by: Frieder Schrempf <frieder.schrempf@online.de>
ghost pushed a commit to fschrempf/user_saml that referenced this issue Jun 17, 2019
Some IdPs send their SLO logout requests via POST. To handle
them we need to add an entry in the routing table.
Further, we need to hack around the issue, that php-saml only
handles GET by copying the request from $_POST to $_GET.

This solves nextcloud#82.

Signed-off-by: Frieder Schrempf <frieder.schrempf@online.de>
@AndyScherzinger AndyScherzinger removed this from the Backlog milestone Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants