Server name from nette/http #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
force-pushed
the
master
branch
2 times, most recently
from
5e75f72 to
db0a128
Compare
|
A better way to do this is to allow the MailSender object to set $host directly, rather than passing the entire Request to it. |
|
Is this ok? |
|
Great, thanks |
dg
pushed a commit
that referenced
this pull request
Jun 20, 2023
dg
pushed a commit
that referenced
this pull request
Jul 30, 2023
dg
pushed a commit
that referenced
this pull request
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using nette behind proxy or in containers, server name is localhost. When nette/http is used, it reads actual host from proxy headers - https://github.com/nette/http/blob/7a92a2a61aaf2ebb74df11bb4a6f56daf20a1ef6/src/Http/RequestFactory.php#L294