-
Notifications
You must be signed in to change notification settings - Fork 19
feat: support for Gatsby v5 #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Include .nvmrc files in both demos to specify minimum node versions.
✅ Deploy Preview for ep-gatsby-v5 canceled.
|
✅ Deploy Preview for netlify-plugin-gatsby-demo canceled.
|
Based on conversations with our build team, this PR is blocked at the moment pending full support for node 18 in our build systems (see this slack thread) and some framework detection enhancements. |
want to test them against both v4 and v5 of Gatsby
also update the github workflow yaml as it was using an invalid value
the parallelization needs to happen within the GH containers instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through the two deploy previews and everything is behaving as expected.
For
Visit the api/users/123 to confirm that the page doesn’t crash (this confirms the updated import logic here works as expected
It doesn’t crash but it returns a message Not found. Is that expected?
Yes that's correct. Prior to the logic introduced here, you would see a function crashing error rather than a 'not found' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for answering my questions @ericapisani! 🚀
Summary
Include .nvmrc files in both demos to specify minimum node versions in order to make it easy to work with now that there are different minimum node versions for the 2 demos.
I opted to create a 2nd demo site as we will have to continue to support v4 for the time being (will be until end of 2023 as that is how long Gatsby will maintain it, though will only have maintenance changes done to it).
I've also updated the minimum version of react to 18 in e2e tests that have
gatsby@next
being installed. We may want to consider having more e2e tests to ensure v4 functionality is maintained, but at the moment e2e tests take a while to run and I wanted to have that discussion with the broader team.Dependant PR: netlify/gatsby-plugin-netlify#203
Migration guide from Gatsby - https://www.gatsbyjs.com/docs/reference/release-notes/migrating-from-v4-to-v5/
Test plan
api/users/123
to confirm that the page doesn't crash (this confirms the updated import logic here works as expectedRelevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes https://github.com/netlify/pod-ecosystem-frameworks/issues/269 , netlify/gatsby-plugin-netlify#195
Standard checks: