Misc code editor additions/fixes #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ctrl+backspace, Ctrl+delete delete adjacent words. - Ctrl+x without selection cuts the entire line. Previously it was implemented but buggy; it copied the line but didn't have a selection to replace. - Outline match supports non-consecutive forward matches, for instance "dph" will match "drawPlayerHit". Matching characters are highlighted in the outline view.
|
This is just some minor editor stuff that I found useful, feel free to take it or leave it. |
|
|
nesbox
requested changes
Dec 2, 2019
nesbox
added
editor: code
|
Sure- I took a quick look and found that it's two separate issues with the undo system. If there is no change (e.g. the cursor doesn't move) there will be no list entry created by Also, undo state is recorded after the action, so the first edit made will always undo the cursor back to the top of the file. I'll spend some time later and try to fix both issues without causing other problems. |
|
Ahh, it looks like a more general issue and doesn't depend on the PR, I'll merge it and create a separate issue then, it will be better. |
nesbox
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was implemented but buggy; it copied the line but didn't have a
selection to replace.
instance "dph" will match "drawPlayerHit". Matching characters are
highlighted in the outline view.