Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CRT shader doesn't work on HTML exports with alone=1 #2229

Closed
scambier opened this issue Jul 5, 2023 · 4 comments
Closed

[Bug] CRT shader doesn't work on HTML exports with alone=1 #2229

scambier opened this issue Jul 5, 2023 · 4 comments
Assignees

Comments

@scambier
Copy link

scambier commented Jul 5, 2023

Version 1.1.2624-dev

When exporting an html with the option alone=1, the CRT shader doesn't work.
It prints these error messages non-stop:

Failed to load vertex shader: [tic80.js:8:23405](http://127.0.0.1:8080/tic80.js)
Error: vertex shader is empty. [tic80.js:8:23405](http://127.0.0.1:8080/tic80.js)
Error: pixel shader is empty.
@nesbox
Copy link
Owner

nesbox commented Aug 14, 2023

can't reproduce on the latest dev

@nesbox nesbox closed this as completed Aug 14, 2023
@scambier
Copy link
Author

scambier commented Aug 19, 2023

Found the issue: the CRT shader works for Lua carts, but not JS (and maybe others) when using alone=1

I guess the CRT code is somehow bounded to Lua, and gets stripped with alone=1

For all examples, I've used the latest stable build (1.1.2729 Pro), and the default language-specific new cart.

@nesbox nesbox reopened this Aug 20, 2023
@nesbox nesbox self-assigned this Aug 24, 2023
@nesbox
Copy link
Owner

nesbox commented Aug 24, 2023

I reproduced it, thanks

@nesbox
Copy link
Owner

nesbox commented Aug 24, 2023

I moved the shader code from config directly to main.c, this allows us to init CRT effect without Lua.
fixed here 5b97399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants