-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: checking multiple files #126
Conversation
Thanks for your review. I did the fixes your suggested. The branch is rebased with main, and my fork is in sync. I can squash if you want, but you can also just "Squash & merge" from GitHub |
OK, I'll do so. |
Thank you! |
You're welcome, happy to help! |
@mtshiba could you please make a new release of pylyzer? I need to have this fix on pypi for the pre-commit hook to work :) |
Discussion #125
About the changes:
When users provide multiple files or patterns to check:
IndexSet
, hope it's okay to add it as a dependancy)Results
You can test it yourself too, but here are a few screenshots:
User provides one valid file and a invalid glob pattern --> exit with 1
Check that duplicates are removed, and ``good2.py´` is analyzed first
Check that options, flags and runtime args are skipped - full example
Next steps
I'm waiting for your review, I'm new to Rust so feel free to tell me what could be improved / done in a more idiomatic way etc...
I ran cargo fmt and cargo clippy, but tell me if there are something else that I need to do.
And I will of course squash everything when we're good, and rebase if you want.