Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy shortcut target path&Update install pkg config&Improving i18n #611

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

XY0797
Copy link
Contributor

@XY0797 XY0797 commented Jan 27, 2025

  1. Add translation files for other languages in setup.wxs.
  2. The appearance of open file location in copy path is clearly incorrect; correct it to copy the target file path of the shortcut.
  3. Testing has revealed that the actual behavior of sel.lnk does not match the documentation; amend the documentation accordingly.

Note:
In Copy the target file path of the shortcut, using where=length(sel.lnk)>0 instead of find='.lnk' is to avoid displaying empty text when a UWP app shortcut is selected.
UWP app shortcut: Open shell:AppsFolder, and you can create one by right-clicking.

Add existing language files
Fixed issue with copying shortcut target file path
Revise the documentation regarding `sel.lnk`
Add `Copy (@sel.count) items selected` to `en.nss`, and add the missing `windows` in `en.nss`
Update the translation of Simplified Chinese
When there is a missing translation item, it will no longer be displayed as blank, but as English
@XY0797 XY0797 changed the title Fix copy shortcut target path&Update install pkg config Fix copy shortcut target path&Update install pkg config&Improving i18n Jan 27, 2025
@XY0797
Copy link
Contributor Author

XY0797 commented Jan 27, 2025

The following additional changes have been made now:

  1. Add Copy (@sel.count) items selected to en.nss
  2. Add the missing windows in en.nss
  3. Update the translation of Simplified Chinese
  4. Update the language loading logic in shell.ns. When there is a missing translation item, it will no longer be displayed as blank, but as English

Note:
New language string loading logic: Always load en.nss first to ensure that English is available for normal display. Then, load the corresponding localization file based on the system language. The configurations loaded later will overwrite those loaded earlier. Therefore, the final effect is that localized strings are displayed with priority, and English is displayed for any untranslated strings.

@moudey moudey merged commit 94adc1d into moudey:main Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants