Skip to content

PHPORM-327 Fix invalid assert in DatabaseSessionHandler::read() #3368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Apr 22, 2025

Fix PHPORM-327
Backports #3366 into branch 5.4

…ted to use the sessions at all with a more simple sanity check (mongodb#3366)

Set zend.assertions=1

---------

Co-authored-by: Toni Vega <toni@flexvega.com>
Co-authored-by: Jérôme Tamarelle <jerome.tamarelle@mongodb.com>
@GromNaN GromNaN added the bug label Apr 22, 2025
@GromNaN GromNaN added this to the 5.4 milestone Apr 22, 2025
@GromNaN GromNaN requested a review from a team as a code owner April 22, 2025 07:53
@GromNaN GromNaN requested a review from alcaeus April 22, 2025 07:53
@GromNaN GromNaN changed the base branch from 5.x to 5.4 April 22, 2025 07:53
@GromNaN GromNaN removed the request for review from alcaeus April 22, 2025 07:53
Copy link

Assigned bisht2050 for team dbx-php because alcaeus is out of office.

@GromNaN GromNaN changed the title Fix invalid assert in DatabaseSessionHandler::read() PHPORM-327 Fix invalid assert in DatabaseSessionHandler::read() Apr 22, 2025
Copy link
Contributor

@bisht2050 bisht2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GromNaN GromNaN merged commit 5a78951 into mongodb:5.4 Apr 22, 2025
71 checks passed
@GromNaN GromNaN deleted the PHPORM-327 branch April 22, 2025 08:22
This was referenced Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants