PHPORM-311 Fix Update of numeric field name #3336
Merged
+49
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Apr 8, 2025
| @@ -426,7 +427,7 @@ public function toMql(): array | |||
|
|
|||
| // Add custom query options | |||
| if (count($this->options)) { | |||
| $options = array_merge($options, $this->options); | |||
| $options = array_replace($options, $this->options); | |||
There was a problem hiding this comment.
There's likely no concern for numeric keys here, but as we discussed it's more expressive to use array_replace() when merging options as well.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-311
Fix #3335 @vipinpapnai
array_mergechanges the index of numeric keys, whereasarray_replacekeeps the keys.Checklist