Skip to content

Merges the read operation reorganization into 5.2 #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2025
Merged

Merges the read operation reorganization into 5.2 #3301

merged 6 commits into from
Mar 4, 2025

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Mar 4, 2025

Merges the read operation reorganization into 5.2 (seems like there was an issue where the 5.2 branch was created but not included in the front-ports)

Checklist

  • Add tests and ensure they pass

@rustagir rustagir requested review from a team as code owners March 4, 2025 15:10
@rustagir rustagir requested review from norareidy and jmikola March 4, 2025 15:10
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about inconsistent and/or redundant anchors but LGTM.

@@ -0,0 +1,157 @@
.. _laravel-fundamentals-search-text:
.. _laravel-retrieve-text-search:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These anchors seem inconsistent with the names in retrieve.txt:

.. _laravel-fundamentals-retrieve-documents:
.. _laravel-fundamentals-read-retrieve:

Is there even a need for multiple anchors at the same location? Presumably, the references to these could just be updated to use the same name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some guidelines around moving pages/content - https://wiki.corp.mongodb.com/spaces/DE/pages/201997355/How+To+Add+or+Rename+an+rST+Page+or+Section

That's the reason that this PR contains multiple anchors - preserving the original section headings and adding more targeted ones that match the current file tree structure. We could probably develop better guidelines around the specific words we use in these anchors though!

@rustagir rustagir merged commit f06d944 into 5.2 Mar 4, 2025
123 checks passed
This was referenced Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants