Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command palette sign in command #1214

Merged
merged 3 commits into from
Jul 5, 2019
Merged

Fix command palette sign in command #1214

merged 3 commits into from
Jul 5, 2019

Conversation

RMacfarlane
Copy link
Contributor

@RMacfarlane RMacfarlane commented Jun 5, 2019

Fixes #1213

The pr.signin command was previously reading a property that hadn't been initialized. Changed to read from remotes directly instead.

Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is good. My only question is whether we should check if this._githubRepositories exits or not already when running login as checking all remotes is probably costly (every authority is one API call to the server).

@RMacfarlane
Copy link
Contributor Author

Since this._githubRepositories is initialized to an empty array, it's hard right now to check if its already up to date. And since sign in should be run infrequently, I think it's ok to make the expensive call for now

@RMacfarlane RMacfarlane merged commit 93d489c into master Jul 5, 2019
@RMacfarlane RMacfarlane deleted the rmacfarlane/signin branch September 6, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign in command not working
2 participants