Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y_Visual Studio Code Web Extensions _GitHub Pull request_ Create Pull request_ Screen Reader: Narrator is not announcing the state of Expanded/collapsed for "Create with Option" arrow button #5483

Closed
tripathiakhil429 opened this issue Nov 17, 2023 · 5 comments · Fixed by #5681
Closed

A11y_Visual Studio Code Web Extensions _GitHub Pull request_ Create Pull request_ Screen Reader: Narrator is not announcing the state of Expanded/collapsed for "Create with Option" arrow button #5483

tripathiakhil429 opened this issue Nov 17, 2023 · 5 comments · Fixed by #5681
Assignees
@alexr00
Labels
accessibility bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded

Comments

@tripathiakhil429
Copy link

tripathiakhil429 commented Nov 17, 2023 •
edited
Loading

Actual:

Narrator is not announcing the state of Expanded/collapsed for "Create with Option" arrow button
Note: Similar issue is observed with NVDA also.

Expected:

Narrator should announce the state of Expanded/collapsed for "Create with Option" arrow button

GitHubTags: #A11yMAS;#A11yTCS;#BM_Visual Studio Code Web Extensions_Nov2023;#Visual Studio Code Web Extensions;#ChromiumEdge;#DesktopWeb;#A11ySev2;#Win11;#WCAG1.3.1;#Screen reader;#Narrator; #NVDA;#AIlimited

Environment Details
Application Name: Visual Studio Code Web Extensions
URL: https://insiders.vscode.dev/github/microsoft/vscode-pull-request-github
Operating System: Windows 11 Enterprise Insider Preview(23H2)
OS Build: 25997.1000
Edge version: 120.0.2210.7 (Official build) stable app, dev channel (64-bit)
Screen Reader: Narrator/NVDA
NVDA Version: 2022.4(2022.4.0.27401)

Repro Steps:

1.Turn on Narrator/NVDA
2.Hit the URL: https://insiders.vscode.dev/github/microsoft/vscode-pull-request-github and login with git hub account.
3.Tab to "More Options" button present in the left navigation panel.
4.Tab to GitHub Pull request and press enter.
5.Tab to Create Pull request and press enter
6.Tab to "Create with Option" arrow button.
7.Observe Narrator is not announcing the state of Expanded/collapsed for "Create with Option" arrow button

User Impact:

Screen reader only users will not get the information about the Create with Option arrow button

MAS Reference:

MAS 1.3.1 – Info and Relationships

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

Attachment:

5483.A11y_Visual.Studio.Code.Web.Extensions._GitHub.Pull.request_.Create.Pull.request_.Screen.Reader.Narrator.is.not.announcing.the.state.of.Expandedcollapsed.for.Create.with.Option.arrow.button.webm
5483.A11y_Visual.Studio.Code.Web.Extensions._GitHub.Pull.request_.Create.Pull.request_.Screen.Reader.NVDA.is.not.announcing.the.state.of.Expandedcollapsed.for.Create.with.Option.arrow.button.webm
@alexr00 alexr00 self-assigned this Nov 20, 2023
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Nov 20, 2023
@alexr00 alexr00 added this to the December 2023 milestone Nov 20, 2023
@joaomoreno joaomoreno removed this from the December 2023 milestone Dec 11, 2023
@alexr00 alexr00 added this to the December / January 2024 milestone Dec 11, 2023
@alexr00
Copy link
Member

alexr00 commented Jan 10, 2024

I do see that menu is read when the menu is opened using the "create with option" button

image

Is there something else that should be read?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Jan 10, 2024
@alexr00
Copy link
Member

alexr00 commented Jan 16, 2024

Closing as this appears to already work.

@alexr00 alexr00 closed this as completed Jan 16, 2024
@rzhao271
Copy link
Contributor

Does the expand and collapse button contain an aria-expanded attribute?
Ref https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded#buttons

@rzhao271
Copy link
Contributor

Confirmed that that accessibility attribute isn't there. Reopening.

@rzhao271 rzhao271 reopened this Jan 25, 2024
@rzhao271 rzhao271 added verification-found Issue verification failed and removed info-needed Issue requires more information from poster labels Jan 25, 2024
@alexr00 alexr00 added the candidate Issue identified as probable candidate for fixing in the next release label Jan 26, 2024
@alexr00
Copy link
Member

alexr00 commented Jan 26, 2024

It's actually a menu, so I think that only the expand needs to be there: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded#menu

alexr00 added a commit that referenced this issue Jan 26, 2024
@alexr00
A11y_Visual Studio Code Web Extensions _GitHub Pull request_ Create P…
f5c6649 
…ull request_ Screen Reader: Narrator is not announcing the state of Expanded/collapsed for "Create with Option" arrow button

Fixes #5483
@alexr00 alexr00 mentioned this issue Jan 26, 2024
Merged
@alexr00 alexr00 removed the verification-found Issue verification failed label Jan 26, 2024
alexr00 added a commit that referenced this issue Jan 26, 2024
@alexr00
A11y_Visual Studio Code Web Extensions _GitHub Pull request_ Create P…
52c442e 
…ull request_ Screen Reader: Narrator is not announcing the state of Expanded/collapsed for "Create with Option" arrow button (#5681)

* A11y_Visual Studio Code Web Extensions _GitHub Pull request_ Create Pull request_ Screen Reader: Narrator is not announcing the state of Expanded/collapsed for "Create with Option" arrow button
Fixes #5483

* Fix leak
@rzhao271 rzhao271 added the verified Verification succeeded label Jan 30, 2024
@rzhao271 rzhao271 mentioned this issue Jan 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
accessibility bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
No milestone
4 participants
@joaomoreno @rzhao271 @alexr00 @tripathiakhil429