Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty diff view after reloading #4293

Closed
gregvanl opened this issue Nov 30, 2022 · 2 comments · Fixed by #4423
Closed

Empty diff view after reloading #4293

gregvanl opened this issue Nov 30, 2022 · 2 comments · Fixed by #4423
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2023

Comments

@gregvanl
Copy link

gregvanl commented Nov 30, 2022 •
edited
Loading

Testing microsoft/vscode#167397

on Windows 11

Convert a PR to Draft mode on github.com and then reload VS Code. One the vscode-docs main branch and PRs on sandboxBlog branch

image
@gregvanl
Copy link
Author

gregvanl commented Nov 30, 2022 •
edited
Loading

Tried Pull Request view refresh but still no diff.

Switching branches to vnext, brought back diff view but similar to microsoft/vscode#200972 the Comments view is empty

@gregvanl
Copy link
Author

gregvanl commented Nov 30, 2022 •
edited
Loading

Doesn't seem to be related to Draft mode, I can repro by having the diff view open and then reloading the window.

Closing and reopening the diff view brings back diff view.

@alexr00 alexr00 changed the title Empty diff view after converting PR to Draft Empty diff view after reloading Nov 30, 2022
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Nov 30, 2022
@alexr00 alexr00 added this to the December 2022 milestone Nov 30, 2022
@alexr00 alexr00 transferred this issue from microsoft/vscode Dec 6, 2022
alexr00 added a commit that referenced this issue Jan 20, 2023
@alexr00
Empty diff view after reloading
b5cf02f 
Fixes #4293
@alexr00 alexr00 mentioned this issue Jan 20, 2023
Merged
alexr00 added a commit that referenced this issue Jan 20, 2023
@alexr00
Empty diff view after reloading (#4423)
0f22b64 
Fixes #4293
@gregvanl gregvanl added the verified Verification succeeded label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Empty diff view after reloading microsoft/vscode-pull-request-github
2 participants
@gregvanl @alexr00