Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode.dev/github.dev: Support .github/pull_request_template.md when creating a PR within vscode #3055

Closed
IanMcNelly opened this issue Oct 21, 2021 · 0 comments · Fixed by #3082
Closed

vscode.dev/github.dev: Support .github/pull_request_template.md when creating a PR within vscode #3055

IanMcNelly opened this issue Oct 21, 2021 · 0 comments · Fixed by #3082
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2021

Comments

@IanMcNelly
Copy link

I couldn't find anything mentioning this, but when using vscode in github.dev, the pull_request_template isn't used. For example in this repository, it should display something like:

<!-- Thank you for submitting a Pull Request. Please:
* Read our Pull Request guidelines:
  https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests
* Associate an issue with the Pull Request.
* Ensure that the code is up-to-date with the `main` branch.
* Include a description of the proposed changes and how to test them.
-->

This PR fixes #

but when creating a PR it does not populate anything in the description:
image
@lramos15 lramos15 transferred this issue from microsoft/vscode Oct 21, 2021
@lszomoru lszomoru assigned alexr00 and unassigned lszomoru Oct 25, 2021
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Oct 26, 2021
@alexr00 alexr00 added this to the November 2021 milestone Oct 26, 2021
@alexr00 alexr00 changed the title Support .github/pull_request_template.md when creating a PR within vscode vscode.dev/github.dev: Support .github/pull_request_template.md when creating a PR within vscode Nov 4, 2021
alexr00 added a commit that referenced this issue Nov 4, 2021
@alexr00
Support pull_request_template.md from web
7f7c70a 
Fixes #3055
@alexr00 alexr00 mentioned this issue Nov 4, 2021
Merged
@alexr00 alexr00 mentioned this issue Nov 8, 2021
Closed
@roblourens roblourens added the verified Verification succeeded label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

Successfully merging a pull request may close this issue.

Support pull_request_template.md from web microsoft/vscode-pull-request-github
4 participants
@roblourens @lszomoru @IanMcNelly @alexr00