fix(react-charting): use inline styles in SVG export for better compatibility #33713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Jan 23, 2025
packages/charts/react-charting/src/components/DeclarativeChart/imageExporter.ts
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 27, 2025
packages/charts/react-charting/src/components/DeclarativeChart/imageExporter.ts
Outdated
Show resolved
Hide resolved
krkshitij
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where SVG export fails on platforms that do not support XML DOMParser by replacing embedded stylesheet within SVG (which rely on DOMParser) with inline styles applied directly to the elements.