sample: fix build when clang path contains space #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
requested review from
Alan-Jowett,
dthaler,
dv-msft,
LakshK98,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag,
shankarseal and
vpidatala94
as code owners
dthaler
previously approved these changes
Mar 10, 2025
Alan-Jowett
previously approved these changes
Mar 10, 2025
|
Had the wrong fix, it's easier to include the |
Please update the PR description. :) The fix itself looks good to me. |
dthaler
approved these changes
Mar 10, 2025
Building the sample project fails if the clang path contains a space. Fix this by quoting "$(ClangExec)".
Alan-Jowett
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the sample project fails if the clang path contains a space. Fix this by quoting "$(ClangExec)".