Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Italic version: make the vertical pipe character actually vertical #507

Closed
chtenb opened this issue Jun 10, 2021 · 0 comments · Fixed by #511
Closed

Italic version: make the vertical pipe character actually vertical #507

chtenb opened this issue Jun 10, 2021 · 0 comments · Fixed by #511
Labels
Issue-Feature

Comments

@chtenb
Copy link

chtenb commented Jun 10, 2021

Description of the new feature/enhancement (with images if possible)

Now that we have a dedicated glyph set for the italics, can we fix the fact that the vertical pipe is tilted like a forward slash?

image

  • As you see, when italics are used the pipe looks awkward.
  • Vertical pipes are used in circumstances where they are supposed to sort of connect vertically, e.g. in ASCII tables
  • It's inconsistent with other orthogonal shapes, like dashes etc, which aren't tilted either
  • The vertical pipe may now be mistaken for a forward slash (this actually happened to me when someone else was reading code from my screen)
@aaronbell aaronbell mentioned this issue Jun 17, 2021
Merged
7 tasks
DHowett pushed a commit that referenced this issue Jun 18, 2021
@aaronbell
Add Hebrew and Arabic; rework Italic (#511)
fb0bce6 
Major update! 

This update includes the brand new Arabic and Hebrew language coverage,
along with a variety of bug fixes to the upright and italic fonts. There
has also been a major overhaul of the Cascadia Code Italic lowercase to
make the forms align better with our vision for the font. Enjoy :). 

Supersedes #491

Cascadia Code
* [x] Closes #84 - Arabic language support added!
* [x] Closes #465 - Hebrew language support added!
* [x] Closes #499 - Adjusted base mark positions / set others to be
  ignored in propagateAnchors

Cascadia Code Italic
* [x] Closes #470 - Adjusted slant on cursive forms to feel a bit better
* [x] Closes #468 - Moved cursive forms to `ss01` / `salt` feature 
* [x] Closes #507 - Changed bar / broken bar to be upright for better
  clarity. All ligature forms adjusted.

Both
* [x] Closes #494 - Adjusted `ƒ` in both upright and italic

- Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
  Arabic features PDF] for the exciting new Arabic ligature
  functionality used in Cascadia Code that gives the font greatly
  improved readability and feel more more akin to a text typeface. Don't
  want all that? Don't worry, Cascadia Mono will house a normal version
  of Arabic. 

- Hebrew support added (design by Liron Lavi Turkenich)
- Fixing a bug in the ccmp feature file and added ccmp to the feature
  set in the build script.
- Deleting the (unused) liga feature file
- Vika has reviewed and improved some forms in Cascadia Code upright. 
- /f, /l, /s, /r (and related forms) have been updated to follow more
  'generic' forms. Previous versions have been moved to ss01 / salt OT
  features.

- Changed design of `ƒ` in upright to align better with the standard
  `f`. In the italic, the `ƒ` has been changed to follow the cursive
  version. When `ss01` is applied, the design of the `f` and `ƒ` are
  swapped, and if the `locl` EWE language setting is applied, the 'f'
  swaps for a straight descender version (with cursive `ƒ`).
  Complicated, but achieves supporting everything.

- Entry and exit strokes across the italic lowercase have been rounded
  to better achieve the fun / playful design language that we intended
  for the italic. Other skeletons have been modified as necessary.
  Cyrillic has also been updated for better consistency with the new
  design. 

- Greek lowercase has been updated per feedback from Gerry Leonidas to
  be more cohesive (No longer a mix between a Monday and Friday font.
  All Friday, all the time)

## Validation Steps Performed
All updated reviewed, hinted, and reviewed again :)

[the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell added a commit to aaronbell/cascadia-code that referenced this issue Jun 21, 2021
@aaronbell
Squashed commit of the following:
1263a52 
commit e9aa335
Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com>
Date:   Sat Jun 19 00:42:28 2021 +0600

    Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385)

    Co-authored-by: Aaron <aaronbell@users.noreply.github.com>

commit fb0bce6
Author: Aaron <aaronbell@users.noreply.github.com>
Date:   Fri Jun 18 10:37:03 2021 -0700

    Add Hebrew and Arabic; rework Italic (microsoft#511)

    Major update!

    This update includes the brand new Arabic and Hebrew language coverage,
    along with a variety of bug fixes to the upright and italic fonts. There
    has also been a major overhaul of the Cascadia Code Italic lowercase to
    make the forms align better with our vision for the font. Enjoy :).

    Supersedes microsoft#491

    Cascadia Code
    * [x] Closes microsoft#84 - Arabic language support added!
    * [x] Closes microsoft#465 - Hebrew language support added!
    * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be
      ignored in propagateAnchors

    Cascadia Code Italic
    * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better
    * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature
    * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better
      clarity. All ligature forms adjusted.

    Both
    * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic

    - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
      Arabic features PDF] for the exciting new Arabic ligature
      functionality used in Cascadia Code that gives the font greatly
      improved readability and feel more more akin to a text typeface. Don't
      want all that? Don't worry, Cascadia Mono will house a normal version
      of Arabic.

    - Hebrew support added (design by Liron Lavi Turkenich)
    - Fixing a bug in the ccmp feature file and added ccmp to the feature
      set in the build script.
    - Deleting the (unused) liga feature file
    - Vika has reviewed and improved some forms in Cascadia Code upright.
    - /f, /l, /s, /r (and related forms) have been updated to follow more
      'generic' forms. Previous versions have been moved to ss01 / salt OT
      features.

    - Changed design of `ƒ` in upright to align better with the standard
      `f`. In the italic, the `ƒ` has been changed to follow the cursive
      version. When `ss01` is applied, the design of the `f` and `ƒ` are
      swapped, and if the `locl` EWE language setting is applied, the 'f'
      swaps for a straight descender version (with cursive `ƒ`).
      Complicated, but achieves supporting everything.

    - Entry and exit strokes across the italic lowercase have been rounded
      to better achieve the fun / playful design language that we intended
      for the italic. Other skeletons have been modified as necessary.
      Cyrillic has also been updated for better consistency with the new
      design.

    - Greek lowercase has been updated per feedback from Gerry Leonidas to
      be more cohesive (No longer a mix between a Monday and Friday font.
      All Friday, all the time)

    ## Validation Steps Performed
    All updated reviewed, hinted, and reviewed again :)

    [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell added a commit to aaronbell/cascadia-code that referenced this issue Jun 23, 2021
@aaronbell
Squashed commit of the following:
0f484c6 
commit e9aa335
Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com>
Date:   Sat Jun 19 00:42:28 2021 +0600

    Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385)

    Co-authored-by: Aaron <aaronbell@users.noreply.github.com>

commit fb0bce6
Author: Aaron <aaronbell@users.noreply.github.com>
Date:   Fri Jun 18 10:37:03 2021 -0700

    Add Hebrew and Arabic; rework Italic (microsoft#511)

    Major update!

    This update includes the brand new Arabic and Hebrew language coverage,
    along with a variety of bug fixes to the upright and italic fonts. There
    has also been a major overhaul of the Cascadia Code Italic lowercase to
    make the forms align better with our vision for the font. Enjoy :).

    Supersedes microsoft#491

    Cascadia Code
    * [x] Closes microsoft#84 - Arabic language support added!
    * [x] Closes microsoft#465 - Hebrew language support added!
    * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be
      ignored in propagateAnchors

    Cascadia Code Italic
    * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better
    * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature
    * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better
      clarity. All ligature forms adjusted.

    Both
    * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic

    - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
      Arabic features PDF] for the exciting new Arabic ligature
      functionality used in Cascadia Code that gives the font greatly
      improved readability and feel more more akin to a text typeface. Don't
      want all that? Don't worry, Cascadia Mono will house a normal version
      of Arabic.

    - Hebrew support added (design by Liron Lavi Turkenich)
    - Fixing a bug in the ccmp feature file and added ccmp to the feature
      set in the build script.
    - Deleting the (unused) liga feature file
    - Vika has reviewed and improved some forms in Cascadia Code upright.
    - /f, /l, /s, /r (and related forms) have been updated to follow more
      'generic' forms. Previous versions have been moved to ss01 / salt OT
      features.

    - Changed design of `ƒ` in upright to align better with the standard
      `f`. In the italic, the `ƒ` has been changed to follow the cursive
      version. When `ss01` is applied, the design of the `f` and `ƒ` are
      swapped, and if the `locl` EWE language setting is applied, the 'f'
      swaps for a straight descender version (with cursive `ƒ`).
      Complicated, but achieves supporting everything.

    - Entry and exit strokes across the italic lowercase have been rounded
      to better achieve the fun / playful design language that we intended
      for the italic. Other skeletons have been modified as necessary.
      Cyrillic has also been updated for better consistency with the new
      design.

    - Greek lowercase has been updated per feedback from Gerry Leonidas to
      be more cohesive (No longer a mix between a Monday and Friday font.
      All Friday, all the time)

    ## Validation Steps Performed
    All updated reviewed, hinted, and reviewed again :)

    [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell added a commit to aaronbell/cascadia-code that referenced this issue Jun 23, 2021
@aaronbell
Add Hebrew and Arabic; rework Italic (microsoft#511)
d173336 
Major update!

This update includes the brand new Arabic and Hebrew language coverage,
along with a variety of bug fixes to the upright and italic fonts. There
has also been a major overhaul of the Cascadia Code Italic lowercase to
make the forms align better with our vision for the font. Enjoy :).

Supersedes microsoft#491

Cascadia Code
* [x] Closes microsoft#84 - Arabic language support added!
* [x] Closes microsoft#465 - Hebrew language support added!
* [x] Closes microsoft#499 - Adjusted base mark positions / set others to be
  ignored in propagateAnchors

Cascadia Code Italic
* [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better
* [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature
* [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better
  clarity. All ligature forms adjusted.

Both
* [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic

- Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
  Arabic features PDF] for the exciting new Arabic ligature
  functionality used in Cascadia Code that gives the font greatly
  improved readability and feel more more akin to a text typeface. Don't
  want all that? Don't worry, Cascadia Mono will house a normal version
  of Arabic.

- Hebrew support added (design by Liron Lavi Turkenich)
- Fixing a bug in the ccmp feature file and added ccmp to the feature
  set in the build script.
- Deleting the (unused) liga feature file
- Vika has reviewed and improved some forms in Cascadia Code upright.
- /f, /l, /s, /r (and related forms) have been updated to follow more
  'generic' forms. Previous versions have been moved to ss01 / salt OT
  features.

- Changed design of `ƒ` in upright to align better with the standard
  `f`. In the italic, the `ƒ` has been changed to follow the cursive
  version. When `ss01` is applied, the design of the `f` and `ƒ` are
  swapped, and if the `locl` EWE language setting is applied, the 'f'
  swaps for a straight descender version (with cursive `ƒ`).
  Complicated, but achieves supporting everything.

- Entry and exit strokes across the italic lowercase have been rounded
  to better achieve the fun / playful design language that we intended
  for the italic. Other skeletons have been modified as necessary.
  Cyrillic has also been updated for better consistency with the new
  design.

- Greek lowercase has been updated per feedback from Gerry Leonidas to
  be more cohesive (No longer a mix between a Monday and Friday font.
  All Friday, all the time)

All updated reviewed, hinted, and reviewed again :)

[the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
@kenmcd kenmcd mentioned this issue Feb 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Hebrew and Arabic; rework Italic aaronbell/cascadia-code
1 participant
@chtenb