Propagate outer type parameters of single signature types #57403

weswigham · 2024-02-13T23:46:46Z

This is wildly more complicated than the issue would make you think, because it uncovers a few issues in how we construct "single signature types" and how that interacts with free type variable inference.

Specifically:

Since we project type parameters from outer signatures onto inner expression types, we need to instantiate argument expressions with the inference context mapper to complete those types. The signature mapper would overeagerly instantiate inner call expressions (one of the new tests demonstrates this), so the inference context itself must be used. This isn't wholly unusual - we already instantiate expression types with the inference context in a number of scenarios (at least in the first inference pass when we're looking to fix argument types, or when the expression is maybe a literal type). This just ensures we always do it when we go to check signature argument expression compatibility.
Since those inner expression types may reference the type parameters of the signature, when we're within the body of a signature and also checking a call to that same signature, we check against a copy of the signature with fresh type parameters, rather than the original, so we don't confuse references to the type parameters of the signature declaration and the inferred type arguments of the nested call.
The single-signature types we produce now capture their outer type parameters (which may come from active inference contexts), so they can be correctly instantiated, so when they contain those projected type parameters, they can be later replaced with the inference results.
We discard inferences of the form [A[0]] for A, since "the first element of A is the first element of A" is a tautological inference that adds no useful information, and always yields A's constraint if selected. This improves inferences in scenarios involving a rest parameter alongside another inference site, as in the linked issue.

…nd signature self-references

typescript-bot · 2024-02-20T21:12:10Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

weswigham · 2024-02-20T21:18:12Z

src/compiler/checker.ts

@@ -34265,7 +34299,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                // If one or more arguments are still excluded (as indicated by CheckMode.SkipContextSensitive),
                // we obtain the regular type of any object literal arguments because we may not have inferred complete
                // parameter types yet and therefore excess property checks may yield false positives (see #17041).
-                const checkArgType = checkMode & CheckMode.SkipContextSensitive ? getRegularTypeOfObjectLiteral(argType) : argType;
+                const checkArgType = instantiateType(checkMode & CheckMode.SkipContextSensitive ? getRegularTypeOfObjectLiteral(argType) : argType, signature.mapper);


You'd think this'd be a noop, and ask questions like "How does an expression within a signature acquire a reference to a type parameter on the source signature?" or "Shouldn't a signature's mapper only need to be applied to the return type?" - and traditionally you'd be right. But at some point we started projecting the signature's type parameters onto expressions in the arguments contextually (and leaving them generic rather than immediately fixing the inference result), so now the arguments may also need the signature mapper applied to typecheck (usually they do not, but the linked issue is one such case where they do).

This instantiation is basically what makes it OK to type the inner expression in the linked issue as A[0], and get the argument to actually instantiate it to number when it flows back into this signature and successfully typecheck.

weswigham · 2024-02-20T21:20:20Z

src/compiler/checker.ts

+                        // TODO: The signature may reference any outer inference contexts, but we map pop off and then apply new inference contexts, and thus get different inferred types.
+                        // That this is cached on the *first* such attempt is not currently an issue, since expression types *also* get cached on the first pass. If we ever properly speculate, though,
+                        // the cached "isolatedSignatureType" signature field absolutely needs to be included in the list of speculative caches.
+                        return getOrCreateTypeFromSignature(instantiateSignatureInContextOf(signature, contextualSignature, context), flatMap(inferenceContexts, c => c && map(c.inferences, i => i.typeParameter)).slice());


This attaches all type variables being inferred in any active inference contexts as potential outer type parameters for this expression type - that allows them to be further instantiated later on (eg, when the signature those type parameters originally came from resolves and tries to map them into the inference results).

weswigham · 2024-02-20T21:22:23Z

src/compiler/checker.ts

+                            // Inferring A to [A[0]] is a zero information inference (it guarantees A becomes its constraint), but oft arises from generic argument list inferences
+                            // By discarding it early, we can allow more fruitful results to be used instead.
+                            if (isTupleOfSelf(inference.typeParameter, candidate)) {
+                                return;


As the comment says, this just discards the bad inference so we can prefer the good one in the example in the linked issue. I think it's a good rule. Without it, we'd infer unknown (from the constraint, since we'd prefer the contravariant [A[0]] to [number]), instead of number.

weswigham · 2024-02-20T21:24:26Z

src/compiler/checker.ts

+                type.symbol.declarations = [signature.declaration];
+                type.symbol.valueDeclaration = signature.declaration;
+            }
+            outerTypeParameters ||= signature.declaration && getOuterTypeParameters(signature.declaration, /*includeThisTypes*/ true);


This gets the default outer type parameters syntactically, as is normal for most locations. The only exception is the inference context-affected case (which is also the interesting one for this issue), where we may affix type parameters to expressions from places not syntactically enclosing the signature.

src/compiler/checker.ts

weswigham · 2024-02-20T21:27:54Z

@typescript-bot run dt
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot perf test public

typescript-bot · 2024-02-20T21:27:58Z

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at f2f9df0. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-20T21:27:58Z

Heya @weswigham, I've started to run the diff-based user code test suite on this PR at f2f9df0. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-20T21:27:58Z

Heya @weswigham, I've started to run the public perf test suite on this PR at f2f9df0. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-20T21:27:58Z

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at f2f9df0. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-20T21:48:19Z

@weswigham Here are the results of running the user test suite comparing main and refs/pull/57403/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-02-20T21:58:08Z

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{mui-docs - node (v20.5.1, x64)}
_{Memory used}	_{2,405,836k (± 0.01%)}	_{2,407,028k (± 0.01%)}	_{+1,193k (+ 0.05%)}	_2,406,898k	_2,407,217k	_{p=0.005 n=6}
_{Parse Time}	_{12.16s (± 1.46%)}	_{12.34s (± 2.99%)}	_~	_12.08s	_13.08s	_{p=0.128 n=6}
_{Bind Time}	_{2.68s (± 0.56%)}	_{2.68s (± 0.93%)}	_~	_2.63s	_2.70s	_{p=0.869 n=6}
_{Check Time}	_{98.26s (± 2.73%)}	_{97.89s (± 2.46%)}	_~	_94.58s	_100.80s	_{p=0.689 n=6}
_{Emit Time}	_{0.30s (± 1.79%)}	_{0.31s (± 1.68%)}	_~	_0.30s	_0.31s	_{p=0.640 n=6}
_{Total Time}	_{113.41s (± 2.47%)}	_{113.22s (± 1.96%)}	_~	_110.64s	_115.95s	_{p=0.936 n=6}
_{self-build-src - node (v20.5.1, x64)}
_{Memory used}	_{2,638,469k (± 5.37%)}	_{2,663,877k (± 5.35%)}	_~	_2,581,304k	_2,929,728k	_{p=0.093 n=6}
_{Parse Time}	_{5.08s (± 1.08%)}	_{5.10s (± 0.86%)}	_~	_5.06s	_5.18s	_{p=0.423 n=6}
_{Bind Time}	_{1.98s (± 0.74%)}	_{1.98s (± 1.00%)}	_~	_1.95s	_2.01s	_{p=0.397 n=6}
_{Check Time}	_{32.31s (± 0.30%)}	_{32.50s (± 0.41%)}	_{+0.19s (+ 0.58%)}	_32.33s	_32.73s	_{p=0.030 n=6}
_{Emit Time}	_{2.81s (± 3.37%)}	_{2.84s (± 1.69%)}	_~	_2.77s	_2.91s	_{p=0.296 n=6}
_{Total Time}	_{42.18s (± 0.42%)}	_{42.42s (± 0.22%)}	_{+0.24s (+ 0.57%)}	_42.34s	_42.58s	_{p=0.020 n=6}
_{self-compiler - node (v20.5.1, x64)}
_{Memory used}	_{418,551k (± 0.02%)}	_{419,163k (± 0.02%)}	_{+611k (+ 0.15%)}	_419,079k	_419,247k	_{p=0.005 n=6}
_{Parse Time}	_{2.89s (± 0.56%)}	_{2.90s (± 1.36%)}	_~	_2.83s	_2.95s	_{p=0.681 n=6}
_{Bind Time}	_{1.13s (± 0.46%)}	_{1.14s (± 0.72%)}	_~	_1.13s	_1.15s	_{p=0.523 n=6}
_{Check Time}	_{14.21s (± 0.33%)}	_{14.37s (± 0.29%)}	_{+0.16s (+ 1.14%)}	_14.31s	_14.43s	_{p=0.005 n=6}
_{Emit Time}	_{1.04s (± 1.70%)}	_{1.04s (± 1.22%)}	_~	_1.03s	_1.06s	_{p=0.607 n=6}
_{Total Time}	_{19.27s (± 0.23%)}	_{19.45s (± 0.18%)}	_{+0.18s (+ 0.93%)}	_19.41s	_19.50s	_{p=0.005 n=6}
_{vscode - node (v20.5.1, x64)}
_{Memory used}	_{2,889,604k (± 0.01%)}	_{2,895,260k (± 0.00%)}	_{+5,655k (+ 0.20%)}	_2,895,233k	_2,895,295k	_{p=0.005 n=6}
_{Parse Time}	_{10.86s (± 0.19%)}	_{10.89s (± 0.28%)}	_~	_10.84s	_10.92s	_{p=0.090 n=6}
_{Bind Time}	_{3.49s (± 0.47%)}	_{3.49s (± 0.40%)}	_~	_3.47s	_3.51s	_{p=0.869 n=6}
_{Check Time}	_{58.35s (± 0.55%)}	_{58.73s (± 0.60%)}	_{+0.38s (+ 0.66%)}	_58.29s	_59.18s	_{p=0.045 n=6}
_{Emit Time}	_{17.16s (± 8.97%)}	_{16.55s (± 0.74%)}	_~	_16.39s	_16.68s	_{p=0.810 n=6}
_{Total Time}	_{89.86s (± 2.04%)}	_{89.66s (± 0.38%)}	_~	_89.33s	_90.17s	_{p=0.128 n=6}
_{webpack - node (v20.5.1, x64)}
_{Memory used}	_{398,811k (± 0.00%)}	_{399,482k (± 0.01%)}	_{+671k (+ 0.17%)}	_399,451k	_399,566k	_{p=0.005 n=6}
_{Parse Time}	_{3.38s (± 0.31%)}	_{3.39s (± 0.39%)}	_~	_3.38s	_3.41s	_{p=0.181 n=6}
_{Bind Time}	_{1.45s (± 0.84%)}	_{1.45s (± 0.35%)}	_~	_1.45s	_1.46s	_{p=0.672 n=6}
_{Check Time}	_{13.10s (± 0.15%)}	_{13.10s (± 0.20%)}	_~	_13.05s	_13.13s	_{p=0.934 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{17.93s (± 0.14%)}	_{17.94s (± 0.16%)}	_~	_17.90s	_17.98s	_{p=0.747 n=6}

System info unknown

Hosts

node (v20.5.1, x64)

Scenarios

mui-docs - node (v20.5.1, x64)
self-build-src - node (v20.5.1, x64)
self-compiler - node (v20.5.1, x64)
vscode - node (v20.5.1, x64)
webpack - node (v20.5.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-02-20T22:12:44Z

Hey @weswigham, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-02-20T22:36:42Z

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/57403/merge:

Something interesting changed - please have a look.

Details

pmndrs/zustand

tsconfig.json

error TS2345: Argument of type 'V' is not assignable to parameter of type 'Result'.
- src/middleware/persist.ts#L182

weswigham · 2024-02-21T19:38:49Z

@typescript-bot pack this

typescript-bot · 2024-02-21T19:38:52Z

Heya @weswigham, I've started to run the tarball bundle task on this PR at f2f9df0. You can monitor the build here.

typescript-bot · 2024-02-21T19:40:41Z

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159965/artifacts?artifactName=tgz&fileId=4EF81D5ED0773B8988644BE963B90A1E680E7AE3BAC9D649A76C45B8DEB20E4A02&fileName=/typescript-5.5.0-insiders.20240221.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-57403-12".;

…xpressions with the context, rather than the signature mapper

weswigham · 2024-02-21T22:30:28Z

@typescript-bot run dt
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot perf test public

typescript-bot · 2024-02-21T22:30:31Z

Heya @weswigham, I've started to run the public perf test suite on this PR at 0822f33. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-21T22:30:31Z

Heya @weswigham, I've started to run the diff-based user code test suite on this PR at 0822f33. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-21T22:30:31Z

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 0822f33. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-21T22:30:31Z

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at 0822f33. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-21T22:49:16Z

@weswigham Here are the results of running the user test suite comparing main and refs/pull/57403/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-02-21T23:00:51Z

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{mui-docs - node (v20.5.1, x64)}
_{Memory used}	_{2,405,820k (± 0.01%)}	_{2,406,974k (± 0.01%)}	_{+1,154k (+ 0.05%)}	_2,406,696k	_2,407,147k	_{p=0.005 n=6}
_{Parse Time}	_{12.14s (± 1.04%)}	_{12.36s (± 1.78%)}	_~	_12.03s	_12.63s	_{p=0.149 n=6}
_{Bind Time}	_{2.67s (± 0.69%)}	_{2.80s (±11.70%)}	_~	_2.64s	_3.47s	_{p=0.872 n=6}
_{Check Time}	_{98.33s (± 2.78%)}	_{97.94s (± 2.66%)}	_~	_93.68s	_100.89s	_{p=1.000 n=6}
_{Emit Time}	_{0.31s (± 0.00%)}	_{0.65s (±128.00%)}	_~	_0.31s	_2.35s	_{p=0.405 n=6}
_{Total Time}	_{113.45s (± 2.48%)}	_{113.75s (± 2.63%)}	_~	_109.49s	_117.61s	_{p=0.936 n=6}
_{self-build-src - node (v20.5.1, x64)}
_{Memory used}	_{2,638,383k (± 5.37%)}	_{2,581,747k (± 0.02%)}	_~	_2,581,134k	_2,582,214k	_{p=0.066 n=6}
_{Parse Time}	_{5.05s (± 0.96%)}	_{5.10s (± 0.87%)}	_~	_5.03s	_5.16s	_{p=0.109 n=6}
_{Bind Time}	_{1.99s (± 1.41%)}	_{2.00s (± 1.09%)}	_~	_1.97s	_2.03s	_{p=0.686 n=6}
_{Check Time}	_{32.35s (± 0.16%)}	_{32.57s (± 0.26%)}	_{+0.22s (+ 0.66%)}	_32.50s	_32.71s	_{p=0.005 n=6}
_{Emit Time}	_{2.80s (± 2.23%)}	_{2.77s (± 4.12%)}	_~	_2.59s	_2.95s	_{p=0.689 n=6}
_{Total Time}	_{42.21s (± 0.23%)}	_{42.46s (± 0.45%)}	_{+0.25s (+ 0.59%)}	_42.20s	_42.71s	_{p=0.025 n=6}
_{self-compiler - node (v20.5.1, x64)}
_{Memory used}	_{418,544k (± 0.02%)}	_{419,112k (± 0.01%)}	_{+569k (+ 0.14%)}	_419,028k	_419,161k	_{p=0.005 n=6}
_{Parse Time}	_{2.89s (± 0.66%)}	_{2.89s (± 0.87%)}	_~	_2.85s	_2.92s	_{p=0.872 n=6}
_{Bind Time}	_{1.13s (± 0.66%)}	_{1.14s (± 0.45%)}	_~	_1.13s	_1.14s	_{p=0.247 n=6}
_{Check Time}	_{14.19s (± 0.11%)}	_{14.32s (± 0.26%)}	_{+0.13s (+ 0.88%)}	_14.25s	_14.36s	_{p=0.005 n=6}
_{Emit Time}	_{1.03s (± 1.00%)}	_{1.05s (± 1.64%)}	_~	_1.03s	_1.07s	_{p=0.114 n=6}
_{Total Time}	_{19.25s (± 0.16%)}	_{19.39s (± 0.20%)}	_{+0.14s (+ 0.73%)}	_19.31s	_19.42s	_{p=0.005 n=6}
_{vscode - node (v20.5.1, x64)}
_{Memory used}	_{2,890,448k (± 0.00%)}	_{2,893,599k (± 0.01%)}	_{+3,151k (+ 0.11%)}	_2,893,294k	_2,893,709k	_{p=0.005 n=6}
_{Parse Time}	_{10.87s (± 0.13%)}	_{10.85s (± 0.32%)}	_~	_10.82s	_10.90s	_{p=0.466 n=6}
_{Bind Time}	_{3.49s (± 0.89%)}	_{3.49s (± 0.49%)}	_~	_3.46s	_3.51s	_{p=0.366 n=6}
_{Check Time}	_{58.49s (± 0.31%)}	_{58.60s (± 0.39%)}	_~	_58.28s	_58.90s	_{p=0.423 n=6}
_{Emit Time}	_{16.60s (± 0.27%)}	_{17.18s (± 8.85%)}	_~	_16.46s	_20.29s	_{p=0.936 n=6}
_{Total Time}	_{89.45s (± 0.26%)}	_{90.13s (± 1.79%)}	_~	_89.15s	_93.39s	_{p=0.689 n=6}
_{webpack - node (v20.5.1, x64)}
_{Memory used}	_{399,033k (± 0.01%)}	_{399,328k (± 0.01%)}	_{+295k (+ 0.07%)}	_399,271k	_399,422k	_{p=0.005 n=6}
_{Parse Time}	_{3.38s (± 0.45%)}	_{3.38s (± 0.31%)}	_~	_3.36s	_3.39s	_{p=0.934 n=6}
_{Bind Time}	_{1.45s (± 0.80%)}	_{1.45s (± 1.07%)}	_~	_1.43s	_1.47s	_{p=0.869 n=6}
_{Check Time}	_{13.11s (± 0.31%)}	_{13.11s (± 0.21%)}	_~	_13.08s	_13.15s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{17.94s (± 0.24%)}	_{17.94s (± 0.25%)}	_~	_17.89s	_17.99s	_{p=0.872 n=6}

System info unknown

Hosts

node (v20.5.1, x64)

Scenarios

mui-docs - node (v20.5.1, x64)
self-build-src - node (v20.5.1, x64)
self-compiler - node (v20.5.1, x64)
vscode - node (v20.5.1, x64)
webpack - node (v20.5.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-02-21T23:14:15Z

Hey @weswigham, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-02-21T23:42:52Z

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/57403/merge:

Something interesting changed - please have a look.

Details

immich-app/immich

5 of 8 projects failed to build with the old tsc and were ignored

server/tsconfig.build.json

error TS2322: Type '((T & object)[keyof T] & object)[keyof (T & object)[keyof T]]' is not assignable to type 'T[keyof T] | undefined'.
- server/src/immich/app.utils.ts#L107

server/tsconfig.json

error TS2322: Type '((T & object)[keyof T] & object)[keyof (T & object)[keyof T]]' is not assignable to type 'T[keyof T] | undefined'.
- server/src/immich/app.utils.ts#L107

microsoft/vscode

3 of 54 projects failed to build with the old tsc and were ignored

src/tsconfig.json

error TS2322: Type '((T & object)[Extract<keyof T, string>] & object)[Extract<keyof (T & object)[Extract<keyof T, string>], string>]' is not assignable to type '(T & object)[Extract<keyof T, string>]'.
- src/vs/editor/common/config/editorOptions.ts#L1016

src/tsconfig.monaco.json

error TS2322: Type '((T & object)[Extract<keyof T, string>] & object)[Extract<keyof (T & object)[Extract<keyof T, string>], string>]' is not assignable to type '(T & object)[Extract<keyof T, string>]'.
- src/vs/editor/common/config/editorOptions.ts#L1016

src/tsconfig.tsec.json

error TS2322: Type '((T & object)[Extract<keyof T, string>] & object)[Extract<keyof (T & object)[Extract<keyof T, string>], string>]' is not assignable to type '(T & object)[Extract<keyof T, string>]'.
- src/vs/editor/common/config/editorOptions.ts#L1016

pmndrs/zustand

tsconfig.json

error TS2345: Argument of type 'Result' is not assignable to parameter of type 'V'.
- src/middleware/persist.ts#L182

fatcerberus · 2024-02-29T00:15:44Z

*propagate. Sorry, I had to.

weswigham · 2024-02-29T17:41:09Z

@typescript-bot run dt
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot perf test public

typescript-bot · 2024-02-29T17:41:12Z

Heya @weswigham, I've started to run the diff-based user code test suite on this PR at 17cbcca. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-29T17:41:12Z

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at 17cbcca. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-29T17:41:12Z

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 17cbcca. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-29T17:41:12Z

Heya @weswigham, I've started to run the public perf test suite on this PR at 17cbcca. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-02-29T17:58:20Z

@weswigham Here are the results of running the user test suite comparing main and refs/pull/57403/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-02-29T18:13:34Z

Hey @weswigham, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-02-29T18:15:49Z

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v20.5.1, x64)}
_{Memory used}	_{191,643k (± 1.08%)}	_{192,367k (± 0.95%)}	_~	_189,823k	_193,549k	_{p=0.230 n=6}
_{Parse Time}	_{1.37s (± 1.11%)}	_{1.38s (± 0.30%)}	_{+0.02s (+ 1.22%)}	_1.38s	_1.39s	_{p=0.045 n=6}
_{Bind Time}	_{0.75s (± 1.19%)}	_{0.75s (± 1.38%)}	_~	_0.73s	_0.76s	_{p=0.673 n=6}
_{Check Time}	_{8.91s (± 0.92%)}	_{8.94s (± 0.99%)}	_~	_8.81s	_9.06s	_{p=0.748 n=6}
_{Emit Time}	_{2.69s (± 0.87%)}	_{2.69s (± 0.99%)}	_~	_2.64s	_2.71s	_{p=1.000 n=6}
_{Total Time}	_{13.72s (± 0.69%)}	_{13.75s (± 0.68%)}	_~	_13.63s	_13.90s	_{p=0.470 n=6}
_{mui-docs - node (v20.5.1, x64)}
_{Memory used}	_{2,407,726k (± 0.01%)}	_{2,409,052k (± 0.00%)}	_{+1,327k (+ 0.06%)}	_2,408,912k	_2,409,103k	_{p=0.005 n=6}
_{Parse Time}	_{12.22s (± 0.64%)}	_{12.26s (± 1.29%)}	_~	_12.09s	_12.52s	_{p=0.747 n=6}
_{Bind Time}	_{2.78s (±10.47%)}	_{2.66s (± 0.84%)}	_~	_2.64s	_2.70s	_{p=0.807 n=6}
_{Check Time}	_{98.14s (± 2.27%)}	_{97.45s (± 1.26%)}	_~	_95.76s	_99.16s	_{p=0.936 n=6}
_{Emit Time}	_{0.30s (± 1.70%)}	_{0.31s (± 1.68%)}	_~	_0.30s	_0.31s	_{p=0.311 n=6}
_{Total Time}	_{113.45s (± 2.01%)}	_{112.67s (± 1.14%)}	_~	_111.04s	_114.66s	_{p=0.689 n=6}
_{self-build-src - node (v20.5.1, x64)}
_{Memory used}	_{2,561,690k (± 0.02%)}	_{2,620,073k (± 5.35%)}	_{+58,382k (+ 2.28%)}	_2,561,764k	_2,906,390k	_{p=0.020 n=6}
_{Parse Time}	_{5.22s (± 0.80%)}	_{5.22s (± 0.63%)}	_~	_5.18s	_5.26s	_{p=0.686 n=6}
_{Bind Time}	_{2.02s (± 0.41%)}	_{2.02s (± 0.49%)}	_~	_2.01s	_2.03s	_{p=0.588 n=6}
_{Check Time}	_{32.39s (± 0.29%)}	_{32.59s (± 0.39%)}	_{+0.20s (+ 0.62%)}	_32.38s	_32.74s	_{p=0.025 n=6}
_{Emit Time}	_{2.73s (± 1.40%)}	_{2.75s (± 1.79%)}	_~	_2.70s	_2.81s	_{p=0.521 n=6}
_{Total Time}	_{42.39s (± 0.21%)}	_{42.59s (± 0.31%)}	_{+0.20s (+ 0.47%)}	_42.47s	_42.78s	_{p=0.031 n=6}
_{self-compiler - node (v20.5.1, x64)}
_{Memory used}	_{413,988k (± 0.01%)}	_{414,778k (± 0.02%)}	_{+790k (+ 0.19%)}	_414,707k	_414,890k	_{p=0.005 n=6}
_{Parse Time}	_{2.90s (± 0.36%)}	_{2.88s (± 0.38%)}	_{-0.02s (- 0.52%)}	_2.86s	_2.89s	_{p=0.046 n=6}
_{Bind Time}	_{1.13s (± 0.36%)}	_{1.14s (± 1.36%)}	_~	_1.12s	_1.16s	_{p=0.421 n=6}
_{Check Time}	_{14.13s (± 0.27%)}	_{14.21s (± 0.28%)}	_{+0.08s (+ 0.58%)}	_14.17s	_14.26s	_{p=0.024 n=6}
_{Emit Time}	_{1.01s (± 1.61%)}	_{1.02s (± 1.07%)}	_~	_1.00s	_1.03s	_{p=0.560 n=6}
_{Total Time}	_{19.17s (± 0.23%)}	_{19.25s (± 0.21%)}	_{+0.08s (+ 0.42%)}	_19.19s	_19.31s	_{p=0.016 n=6}
_{vscode - node (v20.5.1, x64)}
_{Memory used}	_{2,896,603k (± 0.00%)}	_{2,899,854k (± 0.00%)}	_{+3,251k (+ 0.11%)}	_2,899,828k	_2,899,878k	_{p=0.005 n=6}
_{Parse Time}	_{10.87s (± 0.15%)}	_{10.90s (± 0.27%)}	_~	_10.86s	_10.94s	_{p=0.255 n=6}
_{Bind Time}	_{3.51s (± 0.28%)}	_{3.50s (± 0.50%)}	_~	_3.47s	_3.52s	_{p=0.216 n=6}
_{Check Time}	_{58.44s (± 0.31%)}	_{58.55s (± 0.50%)}	_~	_58.16s	_58.93s	_{p=0.471 n=6}
_{Emit Time}	_{16.51s (± 0.25%)}	_{16.58s (± 0.61%)}	_~	_16.46s	_16.73s	_{p=0.295 n=6}
_{Total Time}	_{89.34s (± 0.24%)}	_{89.52s (± 0.43%)}	_~	_89.01s	_89.98s	_{p=0.378 n=6}
_{webpack - node (v20.5.1, x64)}
_{Memory used}	_{400,027k (± 0.00%)}	_{400,377k (± 0.01%)}	_{+350k (+ 0.09%)}	_400,344k	_400,426k	_{p=0.005 n=6}
_{Parse Time}	_{3.41s (± 0.80%)}	_{3.39s (± 0.90%)}	_~	_3.35s	_3.43s	_{p=0.564 n=6}
_{Bind Time}	_{1.42s (± 0.69%)}	_{1.42s (± 0.97%)}	_~	_1.41s	_1.44s	_{p=0.677 n=6}
_{Check Time}	_{13.06s (± 0.27%)}	_{13.08s (± 0.18%)}	_~	_13.05s	_13.11s	_{p=0.419 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{17.89s (± 0.21%)}	_{17.89s (± 0.22%)}	_~	_17.84s	_17.95s	_{p=1.000 n=6}

System info unknown

Hosts

node (v20.5.1, x64)

Scenarios

Compiler-Unions - node (v20.5.1, x64)
mui-docs - node (v20.5.1, x64)
self-build-src - node (v20.5.1, x64)
self-compiler - node (v20.5.1, x64)
vscode - node (v20.5.1, x64)
webpack - node (v20.5.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-02-29T18:24:03Z

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/57403/merge:

Everything looks good!

weswigham · 2024-03-05T21:13:33Z

@typescript-bot pack this

typescript-bot · 2024-03-05T21:13:35Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started

typescript-bot · 2024-03-05T21:15:15Z

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/160206/artifacts?artifactName=tgz&fileId=574D6E6658D6BECD4725E72A38C2D5C994F69D0856AA6F4862446837309E87CE02&fileName=/typescript-5.5.0-insiders.20240305.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-57403-34".;

jakebailey

From what I remember from your previous explanation, this seemed good to go?

jakebailey · 2024-03-25T22:26:38Z

src/compiler/checker.ts

@@ -7088,7 +7089,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {

                const abstractSignatures = filter(resolved.constructSignatures, signature => !!(signature.flags & SignatureFlags.Abstract));
                if (some(abstractSignatures)) {
-                    const types = map(abstractSignatures, getOrCreateTypeFromSignature);
+                    const types = map(abstractSignatures, s => getOrCreateTypeFromSignature(s));


Is this leftover from a previous refactor?

Oh, it's just the second optional param not being assignable to map's param.

Propegate outer type parameters of single signature types

1ea52a4

typescript-bot assigned weswigham Feb 13, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Feb 13, 2024

weswigham mentioned this pull request Feb 13, 2024

nested generic function inference causes unbound type parameter leak #55467

Closed

Move where instantiation happens out a call, clean up edge cases arou…

f2f9df0

…nd signature self-references

weswigham commented Feb 20, 2024

View reviewed changes

Merge branch 'main' into free-type-variable-leak

f5ee1c4

Rather than creating new type identities, only instantiate argument e…

0822f33

…xpressions with the context, rather than the signature mapper

weswigham changed the title ~~Propegate outer type parameters of single signature types~~ Propagate outer type parameters of single signature types Feb 29, 2024

Fix borked test, re-add type parameter copying

17cbcca

weswigham marked this pull request as ready for review February 29, 2024 19:36

weswigham requested review from sandersn and ahejlsberg February 29, 2024 19:37

RyanCavanaugh mentioned this pull request Mar 5, 2024

Design Meeting Notes, 2024-03-05 #57655

Closed

1 task

jakebailey approved these changes Mar 25, 2024

View reviewed changes

weswigham merged commit e1874f3 into microsoft:main Mar 27, 2024

This was referenced Mar 28, 2024

Type parameter can leak out of a function instead of being bound to specific type #43961

Closed

Fixed single signature type parameter leak #58008

Merged

MichaelMitchell-at mentioned this pull request Apr 12, 2024

[nightly][regression] Wrong generic parameter inferred for constructed class instance #58158

Closed

Andarist mentioned this pull request Jan 22, 2025

Use proper type parameter hosts in JS files #61013

Open

Andarist mentioned this pull request Mar 30, 2025

Cache mapper instantiations #61505

Open

Propagate outer type parameters of single signature types #57403

Propagate outer type parameters of single signature types #57403

Conversation

weswigham commented Feb 13, 2024 • edited Loading

typescript-bot commented Feb 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

weswigham Feb 20, 2024 • edited Loading

Choose a reason for hiding this comment

weswigham commented Feb 20, 2024

typescript-bot commented Feb 20, 2024 • edited Loading

typescript-bot commented Feb 20, 2024 • edited Loading

typescript-bot commented Feb 20, 2024 • edited Loading

typescript-bot commented Feb 20, 2024 • edited Loading

typescript-bot commented Feb 20, 2024

typescript-bot commented Feb 20, 2024

tsc

typescript-bot commented Feb 20, 2024

typescript-bot commented Feb 20, 2024

weswigham commented Feb 21, 2024

typescript-bot commented Feb 21, 2024 • edited Loading

typescript-bot commented Feb 21, 2024 • edited Loading

weswigham commented Feb 21, 2024

typescript-bot commented Feb 21, 2024 • edited Loading

typescript-bot commented Feb 21, 2024 • edited Loading

typescript-bot commented Feb 21, 2024 • edited Loading

typescript-bot commented Feb 21, 2024 • edited Loading

typescript-bot commented Feb 21, 2024

typescript-bot commented Feb 21, 2024

tsc

typescript-bot commented Feb 21, 2024

typescript-bot commented Feb 21, 2024

fatcerberus commented Feb 29, 2024

weswigham commented Feb 29, 2024

typescript-bot commented Feb 29, 2024 • edited Loading

typescript-bot commented Feb 29, 2024 • edited Loading

typescript-bot commented Feb 29, 2024 • edited Loading

typescript-bot commented Feb 29, 2024 • edited Loading

typescript-bot commented Feb 29, 2024

typescript-bot commented Feb 29, 2024

typescript-bot commented Feb 29, 2024

tsc

typescript-bot commented Feb 29, 2024

weswigham commented Mar 5, 2024

typescript-bot commented Mar 5, 2024 • edited Loading

typescript-bot commented Mar 5, 2024 • edited Loading

jakebailey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

weswigham commented Feb 13, 2024 •

edited

Loading

weswigham Feb 20, 2024 •

edited

Loading

typescript-bot commented Feb 20, 2024 •

edited

Loading

typescript-bot commented Feb 20, 2024 •

edited

Loading

typescript-bot commented Feb 20, 2024 •

edited

Loading

typescript-bot commented Feb 20, 2024 •

edited

Loading

typescript-bot commented Feb 21, 2024 •

edited

Loading

typescript-bot commented Feb 21, 2024 •

edited

Loading

typescript-bot commented Feb 21, 2024 •

edited

Loading

typescript-bot commented Feb 21, 2024 •

edited

Loading

typescript-bot commented Feb 21, 2024 •

edited

Loading

typescript-bot commented Feb 21, 2024 •

edited

Loading

typescript-bot commented Feb 29, 2024 •

edited

Loading

typescript-bot commented Feb 29, 2024 •

edited

Loading

typescript-bot commented Feb 29, 2024 •

edited

Loading

typescript-bot commented Feb 29, 2024 •

edited

Loading

typescript-bot commented Mar 5, 2024 •

edited

Loading

typescript-bot commented Mar 5, 2024 •

edited

Loading