WebUSB: On serial connection check baud rate before setting it. #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-robert
requested changes
Feb 24, 2023
microbit-carlos
commented
Feb 27, 2023
|
Awesome, thanks @microbit-robert! |
|
Ah, there are merge conflicts and it needs to be rebased anyway, I'll do that. |
Setting the baud rate makes DAPLink send a "break signal", which resets the target. This is triggered when switching tabs as it resets the user's micro:bits when the editor goes out of focus and active again.. We can avoid this reset by checking first the DAPLink serial settings and only set the baud rate if necessary.
|
Okay, should be ready for merge now 👍 |
|
Now we've done this it might be worth trying to avoid resetting the serial console (i.e clearing scrollback) in this scenario as that's what most folks have been complaining about. Needs some thought though as serial output that doesn't match the running program is confusing (e.g. we might show a clickable traceback for it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the baud rate makes DAPLink send a "break signal", which basically resets the target.
This is noticeable to the Python Editor users when switching tabs as it makes their programme reset.
We can avoid this reset by checking first the DAPLink serial settings and only set the baud rate if necessary.
For devices with DAPLink 0257 and newer (V2.2) the default baud rate is set to 115200 already, so they will never reset on WebUSB connection. For devices with older DAPLink versions (V1 and V2.00) the editor will set the baud rate on first connection (triggering a reset), but won't have to set it again until the device is unplugged.
I tried to replicate the
Bad response for 8 -> 17issue for about 5 minutes changing tabs and refreshing-and-reconnecting and it seems fine (and also checked that it's really easy to replicate in the Python Editor v2).