NA tcp: Add FI_TAG_RPC support #784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag allows the libfabric to drop messages with unmatched tags. It fixes an issue that the endpoint would be choked if it receives a stale reply and libfabric doesn't know how to handle it. Signed-off-by: Jinshan Xiong <jinshanx@google.com>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
ofi pr: ofiwg/libfabric#10783 |
|
I have read the CLA Document and I hereby sign the CLA |
|
I would move the code to https://github.com/mercury-hpc/mercury/blob/master/src/na/na_ofi.c#L3506 and instead do: |
jxiong
added a commit
to daos-stack/daos
that referenced
this pull request
Feb 25, 2025
Otherwise it would choke the underlying tcp connection. ** a temporary fix on our end while waiting for the libfabric decision ** internal ticket: b/395943619 ofi PR: https://github.com/ofiwg/libfabric/pull/{10792,10783} mercury PR: mercury-hpc/mercury#784 Change-Id: I108417b19f02d027e3bf7ee55165edd43c23d15b Signed-off-by: Jinshan Xiong <jinshanx@google.com>
5 tasks
jxiong
added a commit
to daos-stack/daos
that referenced
this pull request
Feb 25, 2025
Otherwise it would choke the underlying tcp connection. ** a temporary fix on our end while waiting for the libfabric decision ** internal ticket: b/395943619 ofi PR: https://github.com/ofiwg/libfabric/pull/{10792,10783} mercury PR: mercury-hpc/mercury#784 Change-Id: I108417b19f02d027e3bf7ee55165edd43c23d15b Signed-off-by: Jinshan Xiong <jinshanx@google.com>
jxiong
added a commit
to daos-stack/daos
that referenced
this pull request
Feb 26, 2025
Otherwise it would choke the underlying tcp connection. ** a temporary fix on our end while waiting for the libfabric decision ** internal ticket: b/395943619 ofi PR: https://github.com/ofiwg/libfabric/pull/{10792,10783} mercury PR: mercury-hpc/mercury#784 Skip-func-hw-test-medium: false Skip-func-hw-tests-large-md-on-ssd: false Test-provider: ofi+tcp Change-Id: I108417b19f02d027e3bf7ee55165edd43c23d15b Signed-off-by: Jinshan Xiong <jinshanx@google.com>
jolivier23
pushed a commit
to daos-stack/daos
that referenced
this pull request
Feb 27, 2025
Otherwise it would choke the underlying tcp connection. ** a temporary fix on our end while waiting for the libfabric decision ** internal ticket: b/395943619 ofi PR: https://github.com/ofiwg/libfabric/pull/{10792,10783} mercury PR: mercury-hpc/mercury#784 Change-Id: I108417b19f02d027e3bf7ee55165edd43c23d15b Signed-off-by: Jinshan Xiong <jinshanx@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag allows the libfabric to drop messages with unmatched tags. It fixes an issue that an endpoint would be choked if it receives a stale reply and libfabric doesn't know how to handle it.