Skip to content

chore: Remove supported_engines check in CLI #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

Conversation

gau-nernst
Copy link
Contributor

@gau-nernst gau-nernst commented Mar 17, 2025

Describe Your Changes

Closes #1962

For context:

  • There is no good reason why CLI should only allow installing engines prescribed in .cortexrc's supportedEngines. The check should be done on the server-side.
  • This makes it easier to add new engines e.g. upcoming Python vLLM engine feat: vLLM backend #2010. This is because if the user doesn't update his .cortexrc, doing something like cortex engines install vllm will fail otherwise (and we need to add code to somehow update .cortexrc automatically)

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@gau-nernst gau-nernst self-assigned this Mar 17, 2025
@gau-nernst gau-nernst added this to Jan Mar 17, 2025
@gau-nernst gau-nernst added this to the Caffeinated Sloth milestone Mar 17, 2025
@gau-nernst gau-nernst moved this to Needs Review in Jan Mar 17, 2025
@gau-nernst gau-nernst added this to Menlo Mar 17, 2025
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Mar 17, 2025
@gau-nernst gau-nernst merged commit 90c622a into dev Mar 17, 2025
8 checks passed
@gau-nernst gau-nernst deleted the thien/cli_engines_install branch March 17, 2025 05:00
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Jan Mar 17, 2025
@gau-nernst gau-nernst moved this from Investigating to Completed in Menlo Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Completed
Development

Successfully merging this pull request may close these issues.

chore: CLI should not check for .cortexrc's supportedEngines
2 participants