Skip to content

chore: address compiler warnings #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 10, 2025
Merged

chore: address compiler warnings #2072

merged 6 commits into from
Mar 10, 2025

Conversation

github-roushan
Copy link
Contributor

Describe Your Changes

  • This pull request addresses a range of compiler warnings across multiple files, improving code quality and maintainability.
  • It implements handling for [[nodiscard]] attributes where return values were previously being ignored, ensuring proper error checking and resource management.
  • Added comprehensive error checking and logging to provide better diagnostics and identify potential issues during runtime.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-roushan
Copy link
Contributor Author

@vansangpfiev

@github-roushan github-roushan mentioned this pull request Mar 6, 2025
Closed
vansangpfiev
vansangpfiev previously approved these changes Mar 7, 2025
View reviewed changes
@vansangpfiev vansangpfiev self-requested a review March 7, 2025 02:46
@github-roushan
Update command_executor.h
1da8d2b 
use macro PCLOSE to correctly map to _pclose on windows
@qnixsynapse qnixsynapse dismissed vansangpfiev’s stale review March 7, 2025 14:14

Windows CI build failure

@github-roushan
fix typo: revert PCLOSE to _pclose for windows
08af92c 
The PCLOSE macro was mistakenly defined as pclose for Windows. This commit fixes the typo, reverting it back to _pclose
@github-roushan
Copy link
Contributor Author

Screenshot (22)

fixed it @qnixsynapse

@vansangpfiev vansangpfiev changed the title Address Compiler Warnings chore: address compiler warnings Mar 10, 2025
@github-roushan
Copy link
Contributor Author

can we push this as well @sangjanai

@vansangpfiev vansangpfiev merged commit ce5cbe8 into menloresearch:dev Mar 10, 2025
7 of 8 checks passed
@github-roushan github-roushan deleted the remove_warn branch March 12, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

@qnixsynapse qnixsynapse qnixsynapse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@github-roushan @vansangpfiev @qnixsynapse