fix: add Authorization Bearer #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
changed the title
|
Still in progress PR, @ramonpzg @qnixsynapse please help add your thoughts on how we can provide API authentication |
|
As I understand, if an application is attaching the credentials via an Authorization header then the browser cannot automatically authenticate the requests, and CSRF is not possible. |
vansangpfiev
changed the title
vansangpfiev
changed the title
vansangpfiev
changed the title
qnixsynapse
approved these changes
Mar 6, 2025
vansangpfiev
added a commit
that referenced
this pull request
Mar 7, 2025
* fix: add simple authentication * fix: exclude v1/configs --------- Co-authored-by: sangjanai <sang@jan.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request introduces a new feature to support API key authentication and includes several changes across multiple files to implement this functionality. The most important changes include adding the
api_keysfield, updating the configuration handling, and integrating API key validation into the server.API Key Authentication:
engine/common/api_server_configuration.h: Added a newapi_keysfield to theApiServerConfigurationclass, updated the constructor, and modified theToJsonmethod to include theapi_keysfield. [1] [2] [3] [4] [5]Configuration Handling:
engine/services/config_service.cc: Updated theUpdateApiServerConfigurationandGetApiServerConfigurationmethods to handle the newapi_keysfield. [1] [2] [3]engine/utils/config_yaml_utils.cc: Modified theDumpYamlConfigandFromYamlmethods to include theapiKeysfield in the YAML configuration. [1] [2] [3]engine/utils/config_yaml_utils.h: Added theapiKeysfield to theCortexConfigstruct.engine/utils/file_manager_utils.cc: Set the default value for theapiKeysfield in theGetDefaultConfigfunction.Server Integration:
engine/main.cc: Implemented API key validation logic and registered it as a pre-routing advice in the server setup.Fixes Issues
Self Checklist