fix: filter out imported models for model sources #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
changed the title
vansangpfiev
force-pushed
the
s/fix/import-n-remote
branch
from
c4b37cf to
f7194f3
Compare
nguyenhoangthuan99
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes a few important changes to the
engine/database/models.ccandengine/services/model_service.ccfiles. The changes primarily focus on refining the model source filtering and modifying background task processing.Refinements and modifications:
engine/database/models.cc: Updated theGetModelSourcesmethod to exclude models with the source labeled as "imported" from the query results.engine/services/model_service.cc: Commented out theProcessBgrTaskscall in theModelServiceconstructor to prevent background tasks from being processed during initialization.Fixes Issues
Self Checklist