Skip to content

fix: add model author for model source #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

This pull request includes significant changes to the ModelSourceService class and related utilities to enhance the handling of model sources and caching. The key updates involve the introduction of a caching mechanism, renaming variables for clarity, and adding new utility functions.

Enhancements to ModelSourceService:

  • Introduced a caching mechanism to store and retrieve model sources efficiently using a new src_cache_ member and the GenSourceId function. (engine/services/model_source_service.cc: [1] [2] [3] [4]; engine/services/model_source_service.h: [5]
  • Renamed variables from author to hub_author across multiple methods to improve code clarity and consistency. (engine/services/model_source_service.cc: [1] [2] [3] [4] [5] [6] [7] [8] [9]; engine/services/model_source_service.h: [10]

Utility Function Additions:

URL Parsing Improvements:

  • Enhanced the SplitPathParams function to return a boolean indicating success or failure, and updated the FromUrlString function to handle malformed URLs more robustly. (engine/utils/url_parser.h: [1] [2] [3]

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev merged commit b9e9e15 into dev Feb 27, 2025
8 checks passed
@vansangpfiev vansangpfiev deleted the s/fix/model-author branch February 27, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants