Skip to content

fix: add more parameters to server start command #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 17, 2025
Merged

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Feb 26, 2025

Describe Your Changes

This pull request includes several changes to the command-line interface and configuration management in the engine/cli and engine/common directories. The most important changes include adding support for a new github_token configuration option, enhancing the command-line parser to handle empty configuration values, and updating the API server configuration to track changes in the server host.

Enhancements to configuration management:

Enhancements to command-line parser:

image

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Copy link
Contributor

github-actions bot commented Mar 11, 2025

Preview URL: https://933f1d66.cortex-docs.pages.dev

@vansangpfiev vansangpfiev changed the title fix: add more parameters to config command fix: add more parameters to server start command Mar 12, 2025
@vansangpfiev vansangpfiev marked this pull request as ready for review March 12, 2025 03:06
Copy link
Contributor

@qnixsynapse qnixsynapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vansangpfiev vansangpfiev merged commit 9ee8b2b into dev Mar 17, 2025
9 checks passed
@vansangpfiev vansangpfiev deleted the s/fix/config-rc branch March 17, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants