Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes several changes to the
ModelService
and utility files to improve functionality and error handling. The most important changes include adding a method to determine the number of CPU threads, enhancing error handling for file operations, and minor adjustments to file includes.Enhancements to
ModelService
:GetCpuThreads
to determine the number of CPU threads based on the hardware and engine mode. This method is used to set a default value forcpu_threads
if it is not configured. (engine/services/model_service.cc
,engine/services/model_service.h
) [1] [2] [3]Error handling improvements:
GGUFHelper::Load
by checking if the file descriptor is valid and logging an error message if the file cannot be opened. (engine/utils/hardware/gguf/gguf_file.h
)Minor adjustments:
engine/utils/hardware/gguf/gguf_file.h
) [1] [2]Estimation res
inEstimateLLaMACppRun
to ensure it is correctly initialized after parsing the GGUF file. (engine/utils/hardware/gguf/gguf_file_estimate.h
)Fixes Issues
Self Checklist