Skip to content

chore: cherry-pick: symlinked model deletion shouldn't remove original file #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

chore: cherry-pick: symlinked model deletion shouldn't remove original file #1933

merged 1 commit into from
Feb 5, 2025

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@ohaiibuzzle @vansangpfiev @sangjanai
fix: models.cc: symlinked model deletion shouldn't remove original fi…
5dee826 
…le (#1918)

Co-authored-by: vansangpfiev <vansangpfiev@gmail.com>
@vansangpfiev vansangpfiev requested a review from hiento09 February 5, 2025 13:37
hiento09
hiento09 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vansangpfiev vansangpfiev merged commit e435d54 into main Feb 5, 2025
6 checks passed
@vansangpfiev vansangpfiev deleted the chore/cherry-pick-dev branch February 5, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @hiento09 @ohaiibuzzle