Skip to content

fix: models.cc: symlinked model deletion shouldn't remove original file #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025
Merged

fix: models.cc: symlinked model deletion shouldn't remove original file #1918

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22b9b76
fix: models.cc: symlinked model deletion shouldn't remove original file
ohaiibuzzle Feb 3, 2025
2158de7
Merge branch 'dev' into ohaiibuzzle/fix/symlink-deletion
vansangpfiev Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions engine/controllers/models.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,9 @@ void Models::ImportModel(
model_config.files.push_back(modelPath);
auto size = std::filesystem::file_size(modelPath);
model_config.size = size;

// set this so that it doesn't nuke the original file on model deletion
model_entry.branch_name = "imported";
}
model_config.model = modelHandle;
model_config.name = modelName.empty() ? model_config.name : modelName;
Expand Down
Loading